Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Uploading patches for review


+
Rohini Palaniswamy 2013-06-06, 01:21
+
Jarek Jarcec Cecho 2013-06-06, 01:50
Copy link to this message
-
Re: Uploading patches for review
Cheolsoo Park 2013-06-06, 06:53
I agree that we should use the RB more often.
On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho <[EMAIL PROTECTED]>wrote:

> I can definitely recommend using the review board. We are using it already
> in all other projects that I'm participating and it's really helping us out.
>
> Jarcec
>
> On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
> > Hi,
> >     Reviewing uploaded patches for few lines of change is easy. But when
> > the change is more it is hard to read, review is more time consuming and
> at
> > times you have to switch between the patch and eclipse to get more
> context.
> > Without the surrounding code it is also easy to miss things on review.
> Can
> > we make it a practice and decide on putting up the patches in review
> board
> > for review if it is slightly bigger? Commenting on the patch is also a
> > breeze in the review board.
> >
> > Thoughts ???
> >
> > Regards,
> > Rohini
>
+
Julien Le Dem 2013-06-06, 09:02
+
Alan Gates 2013-06-06, 09:25