-Re: Unable to Apply Patch
Matt Foley 2011-10-03, 06:45
thanks for your interest in contributing to Hadoop. The Jira you are
working on was opened against the HDFS component, but your patch (correctly,
I believe) applies against the FS-independent common code. The automated CI
machinery that runs test-patch fails in this situation. So I've moved the
bug from the HDFS component to the HADOOP (common) component (HDFS-364 -->
Having done that, test-patch happily picked it up and gave it a +1.
Congratulations! And thanks for respecting the need for unit tests!
Enabling you to formally be assigned the Jira requires adding you to the
Contributor list for the project. I don't have privs to do that, so
hopefully someone who does will see this and add you. I did add you to the
Watchers list for that jira.
Let's wait until you are added to the Contributors list, and then I'll be
happy to code review your patch, then commit it.
On Sun, Oct 2, 2011 at 7:14 AM, Allen, Jonathan <[EMAIL PROTECTED]>wrote:
> I'm having problems submitting a patch. It's my first attempt at
> submitting something so I assume I'm getting something wrong when generating
> my patch. The patch applies successfully on my local system (using patch
> -p0 < filename) but when I attach it to the jira Hadoop QA reports that it
> could not be applied. I've generated the patch from both Git and SVN and in
> both cases the submission fails.
> https://issues.apache.org/jira/browse/HDFS-364 (very old issue but looked
> like something nice and simple to get my environment set up correctly).
> Does anybody have any thoughts as to what the problem is?
> As an aside, how do I assign the jira to myself?
> Jonathan Allen
> UKGP, NS&R, Defence and Security
> HP Enterprise Services
> Telephone +44 1684 291206
> Email [EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>
> Street address, HP Enterprise Services UK Ltd, Alexandra Way, Ashchurch
> Business Park, Tewkesbury, Gloucestershire. GL20 8NB
> Hewlett-Packard Limited registered Office: Cain Road, Bracknell, Berks RG12
> Registered No: 690597 England
> The contents of this message and any attachments to it are confidential and
> may be legally privileged. If you have received this message in error, you
> should delete it from your system immediately and advise the sender.
> To any recipient of this message within HP, unless otherwise stated you
> should consider this message and attachments as "HP CONFIDENTIAL".