Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hadoop, mail # dev - Resolving find bug issue


+
madhu phatak 2012-06-26, 11:01
+
Robert Evans 2012-06-26, 14:14
Copy link to this message
-
Re: Resolving find bug issue
madhu phatak 2012-06-27, 07:22
Hi Robert,
 Thanks for your input.I have updated the patch with public getter for the
host.

On Tue, Jun 26, 2012 at 7:44 PM, Robert Evans <[EMAIL PROTECTED]> wrote:

> The issue you are running into is because you made the HOST variable
> public, when it was package previously.  Findbugs thinks that you want HOST
> to be a constant because it is ALL CAPS and is only set once and read all
> other times.  By making it public it is now difficult to ensure that it is
> never written to, hence the suggestion to make it final.  I would prefer to
> actually switch it over to private and add in a new public method that
> return the value of HOST.
>
> --Bobby Evans
>
>
> On 6/26/12 6:01 AM, "madhu phatak" <[EMAIL PROTECTED]> wrote:
>
> Hi,
>  I have submitted a patch for jira (HADOOP-8521) which is giving findbug(
> https://issues.apache.org/jira/browse/HADOOP-8521) error. To fix the
> issue,I have to duplicate the StreamUtil class to the newly introduced
> mapreduce package.Is it a good practice or is there other way to fix this?
>
>
> Regards,
> Madhukara Phatak
>
> --
> https://github.com/zinnia-phatak-dev/Nectar
>
>
--
https://github.com/zinnia-phatak-dev/Nectar