Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands


Copy link to this message
-
Re: Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13181/#review27042
-----------------------------------------------------------
Thank you for incorporating the changes Abe, appreciated! I like the changes and I do have just couple of nits from user perspective. I've tried following script:

set server --host my.cool.and.super.secret.host
set option --name verbose --value true
show version --all
create connection --cid 1 --name NameX

With following output:

jarcec@Odie sqoop2 % dist/target/sqoop-2.0.0-SNAPSHOT-bin-hadoop200/bin/sqoop.sh client command.createConnectionInvalid
Sqoop home directory: /home/jarcec/apache/repos/sqoop2/dist/target/sqoop-2.0.0-SNAPSHOT-bin-hadoop200
sqoop:000> set server --host my.cool.and.super.secret.host
Server is set successfully
===> FINE
FINE
sqoop:000> set option --name verbose --value true
Verbose option was changed to true
===> FINE
FINE
sqoop:000> show version --all
client version:
  Sqoop 2.0.0-SNAPSHOT revision 712b26b969187f48553eeab0bf64c26e14190984
  Compiled by jarcec on Tue Oct 15 13:38:11 PDT 2013
server version:
  Sqoop 2.0.0-SNAPSHOT revision 712b26b969187f48553eeab0bf64c26e14190984
  Compiled by jarcec on Tue Oct 15 13:38:11 PDT 2013
Protocol version:
  [1]
===> FINE
FINE
sqoop:000> create connection --cid 1 --name NameX
Creating connection for connector with id 1
Error message: Driver can't be empty
Error message: JDBC URL can't be empty

1) It seems that we are printing the "FINE" string twice, would it be feasible to print it only once?
2) The error messages are not tied to any input, so it's hard to correlate them. Would it be feasible to do something like:

input.driver: ERROR: Driver can't be empty

Jarcec

- Jarek Cecho
On Oct. 14, 2013, 7:05 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13181/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 7:05 p.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-773
>     https://issues.apache.org/jira/browse/SQOOP-773
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 080ced16578c1d95015ce3e99b4335beb465861a
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Tue Aug 13 14:14:06 2013 -0700
>
>     SQOOP-773 Sqoop2: Batch execution support for client commands
>    
>     Separated options into two groups: fixed and dynamic options.
>     Fixed options (IE: connector ID) come first and are used to select
>     what options should be used in dynamic options. Dynamic options
>     are automatically created based on forms selected from fixed options.
>     The keys for these options take on the form "<prefix>-<form name>-<input-name>".
>
> :100644 100644 980a908... a7e7e7d... M  shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java
> :100644 100644 856abaa... 2c2869c... M  shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
> :100644 100644 3e23025... dd2eb2b... M  shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
> :100644 100644 e62ce08... 9ad007b... M  shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
> :100644 100644 5fbf0a3... 973fd53... M  shell/src/main/java/org/apache/sqoop/shell/CreateConnectionFunction.java
> :100644 100644 6e4f04b... f0d4a6c... M  shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
> :100644 100644 c123732... d79516d... M  shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java
> :100644 100644 d4095b7... df9a2cc... M  shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java
> :100644 100644 f119660... b5a54b9... M  shell/src/main/java/org/apache/sqoop/shell/DisableConnectionFunction.java
> :100644 100644 a87e51f... 8cc4ea3... M  shell/src/main/java/org/apache/sqoop/shell/DisableJobFunction.java