Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13051: SQOOP-1154 Sqoop2: Text partitioner might miss or include edge values


Copy link to this message
-
Re: Review Request 13051: SQOOP-1154 Sqoop2: Text partitioner might miss or include edge values

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13051/#review24257
-----------------------------------------------------------

Ship it!
Good point.   Even though these were in line with what we did before, it is important that we have the bounds to include both.

- Venkat Ranganathan
On July 30, 2013, 4:51 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13051/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 4:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1154
>     https://issues.apache.org/jira/browse/SQOOP-1154
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've altered the methods to inject the lower bound into first partition and upper bound to the last partition.
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 8d0c4ab017790985741c7effc6e1e58c54267a02
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java a33dd6cfe7b001f173e155b3fb694c5eb6e7368e
>
> Diff: https://reviews.apache.org/r/13051/diff/
>
>
> Testing
> -------
>
> Altered one unit test and tested in the new integration test that is part of SQOOP-1114.
>
>
> Thanks,
>
> Jarek Cecho
>
>