Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 12440: Fix for Flume-2109, with review comments incorporated


Copy link to this message
-
Re: Review Request 12440: Fix for Flume-2109, with review comments incorporated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12440/#review23306
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
<https://reviews.apache.org/r/12440/#comment47190>

    Whats about SSL port can't be < 0 or empty

flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
<https://reviews.apache.org/r/12440/#comment47191>

    Whats about
    A keystore is required ....
    
    A keystore password is ....

flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/12440/#comment47182>

    Spelling issue:
    
    includng = including
- Alexander Alten-Lorenz
On July 10, 2013, 7:40 a.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12440/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:40 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2109
>     https://issues.apache.org/jira/browse/FLUME-2109
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Flume patch to support HTTPS support. Review comments incorporated. Now only one mode shall be enabled either normal HTTP or HTTPS.
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
>   flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
>
> Diff: https://reviews.apache.org/r/12440/diff/
>
>
> Testing
> -------
>
> Unit test case added to verify SSL functionality.
>
>
> Thanks,
>
> Ashish Paliwal
>
>