-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8650/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've listed all third party jars that are shipped as a part of our server war file.
This addresses bug SQOOP-786.
    https://issues.apache.org/jira/browse/SQOOP-786
Diffs
-----

  LICENSE.txt 09d993d86befd1e6a9267e1371831dd7ac3e3497

Diff: https://reviews.apache.org/r/8650/diff/
Testing
-------
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8650/#review14610
-----------------------------------------------------------
Hi Jarcec,

Here is the dependencies that I see. Do we want to list all of them? If so, I see some missing ones in your patch.

[cheolsoo@cheolsoo-mr2-1 webapps]$ jar -tvf sqoop.war | grep "\.jar" | grep -v hadoop | grep -v sqoop | awk '{ print $8}' | sort -u
WEB-INF/lib/avro-1.7.1.cloudera.2.jar
WEB-INF/lib/commons-cli-1.2.jar
WEB-INF/lib/commons-configuration-1.6.jar
WEB-INF/lib/commons-dbcp-1.4.jar
WEB-INF/lib/commons-lang-2.5.jar
WEB-INF/lib/commons-logging-1.1.1.jar
WEB-INF/lib/commons-pool-1.5.4.jar
WEB-INF/lib/derby-10.8.2.2.jar
WEB-INF/lib/guava-11.0.2.jar
WEB-INF/lib/jackson-core-asl-1.8.8.jar
WEB-INF/lib/jackson-mapper-asl-1.8.8.jar
WEB-INF/lib/json-simple-1.1.jar
WEB-INF/lib/log4j-1.2.16.jar
WEB-INF/lib/protobuf-java-2.4.0a.jar
WEB-INF/lib/slf4j-api-1.6.1.jar
WEB-INF/lib/slf4j-log4j12-1.6.1.jar

- Cheolsoo Park
On Dec. 17, 2012, 8:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8650/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 8:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've listed all third party jars that are shipped as a part of our server war file.
>
>
> This addresses bug SQOOP-786.
>     https://issues.apache.org/jira/browse/SQOOP-786
>
>
> Diffs
> -----
>
>   LICENSE.txt 09d993d86befd1e6a9267e1371831dd7ac3e3497
>
> Diff: https://reviews.apache.org/r/8650/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8650/
-----------------------------------------------------------

(Updated Dec. 17, 2012, 9:35 p.m.)
Review request for Sqoop.
Changes
-------

Hi Chelsoo,
thank you very much for your question. I've originally didn't wanted to repeat myself with jars that are already mentioned in the file, but you're right that it's very confusing. I've removed all paths in the file so that I don't have to repeat myself and at the same time it's not confusing for the user :-)

Thanks!
Jarcec
Description
-------

I've listed all third party jars that are shipped as a part of our server war file.
This addresses bug SQOOP-786.
    https://issues.apache.org/jira/browse/SQOOP-786
Diffs (updated)
-----

  LICENSE.txt 09d993d86befd1e6a9267e1371831dd7ac3e3497

Diff: https://reviews.apache.org/r/8650/diff/
Testing
-------
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8650/#review14618
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Dec. 17, 2012, 9:35 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8650/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 9:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've listed all third party jars that are shipped as a part of our server war file.
>
>
> This addresses bug SQOOP-786.
>     https://issues.apache.org/jira/browse/SQOOP-786
>
>
> Diffs
> -----
>
>   LICENSE.txt 09d993d86befd1e6a9267e1371831dd7ac3e3497
>
> Diff: https://reviews.apache.org/r/8650/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>