-Re: Are we no longer giving credit in SVN commit messages?
Andrew Purtell 2014-01-21, 00:47
Oh, we don't want the "."? It's pretty universal in Hadoop land (just
checked common, hdfs, mapreduce, yarn, and zookeeper).
On Mon, Jan 20, 2014 at 4:46 PM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:
> +1 to andrews format
> HBASE-xxxxx JIRA Title (contributor name)
> One nit is most of our jiras are committed without the '.' after the jira
> name. Not the end of the world if a '.' or ':' sneaks in.
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <[EMAIL PROTECTED]>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> > I've noticed that some committers are definitely not doing this.
> > I think it is bad practice not to provide attribution to the contributor
> > the commit message. When one is reviewing commit history, neither links
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> > that does this of which I'm not aware (please let me know!).
> > --
> > Best regards,
> > - Andy
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // [EMAIL PROTECTED]
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)