Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-1893. File Channel could miss possible checkpoint corruption


Copy link to this message
-
Re: Review Request: FLUME-1893. File Channel could miss possible checkpoint corruption

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9266/#review20348
-----------------------------------------------------------

Ship it!
+1, will run tests and commit

- Mike Percy
On Feb. 2, 2013, 6:46 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9266/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 6:46 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Made sure the comparisons made are long comparisons and we don't miss the Most significant 4 bytes.
>
>
> This addresses bug FLUME-1893.
>     https://issues.apache.org/jira/browse/FLUME-1893
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 7f35301
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d98209b
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 7da8c49
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 170dc72
>
> Diff: https://reviews.apache.org/r/9266/diff/
>
>
> Testing
> -------
>
> Added unit tests for the cases being fixed. All current tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>