Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-2042. log4jappender timeout should be configurable


Copy link to this message
-
Re: Review Request: FLUME-2042. log4jappender timeout should be configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11066/#review20442
-----------------------------------------------------------

Ship it!
+1

If there are no objections I will commit this soon, probably tomorrow.

Hari, can you please attach the newest patch to the JIRA?

- Mike Percy
On May 11, 2013, 2:06 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11066/
> -----------------------------------------------------------
>
> (Updated May 11, 2013, 2:06 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added timeout configuration to both log4j appender and load balancing log4j appender
>
>
> This addresses bug FLUME-2042.
>     https://issues.apache.org/jira/browse/FLUME-2042
>
>
> Diffs
> -----
>
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java 3172e21
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 0ba56d3
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java 103bcb6
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java 211837b
>
> Diff: https://reviews.apache.org/r/11066/diff/
>
>
> Testing
> -------
>
> Added new unit tests. Ran full build, all tests pass.
>
>
> Thanks,
>
> Hari Shreedharan
>
>