Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-534: Add ability to find out if MPersistableEntity do already have persistent ID


Copy link to this message
-
Re: Review Request: SQOOP-534: Add ability to find out if MPersistableEntity do already have persistent ID


> On Aug. 2, 2012, 5:47 p.m., Bilung Lee wrote:
> > Ship It!

Thank you for your review Bilung,
patch is already attached to JIRA, so feel free to commit it.

Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6310/#review9767
-----------------------------------------------------------
On Aug. 1, 2012, 11:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6310/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 11:11 p.m.)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Description
> -------
>
> I've refactored code around default ID value and checking if the value is being set.
>
>
> This addresses bug SQOOP-534.
>     https://issues.apache.org/jira/browse/SQOOP-534
>
>
> Diffs
> -----
>
>   branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MPersistableEntity.java 1368302
>   branches/sqoop2/common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java PRE-CREATION
>   branches/sqoop2/core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 1368302
>   branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1368302
>
> Diff: https://reviews.apache.org/r/6310/diff/
>
>
> Testing
> -------
>
> I've added simple unit test for MPersistableEntity.
>
>
> Thanks,
>
> Jarek Cecho
>
>