Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig >> mail # dev >> Re: Review Request: Review for PIG-2641 - add ToJson builtin to Pig


+
Gunther Hagleitner 2013-02-18, 01:21
+
Prashant Kommireddi 2013-02-18, 05:51
+
Jeremy Karn 2013-02-18, 14:15
+
Jonathan Coveney 2013-02-18, 14:23
+
Russell Jurney 2013-02-18, 23:02
+
Russell Jurney 2013-02-18, 22:43
+
Prashant Kommireddi 2013-02-18, 23:06
+
Russell Jurney 2013-02-18, 23:29
+
Russell Jurney 2013-02-18, 23:04
Copy link to this message
-
Re: Review Request: Review for PIG-2641 - add ToJson builtin to Pig

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9481/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 11:03 p.m.)
Review request for pig, Ashutosh Chauhan, Dmitriy Ryaboy, Alan Gates, Jonathan Coveney, and Bill Graham.
Changes
-------

Implemented all fixes recommended from Gunther, except reusing json - that gives bad output.
Description
-------

This patch is for JIRA, https://issues.apache.org/jira/browse/PIG-2641 PIG-2641 - which adds a ToJson builtin based on the serialization in JsonStorage.
This addresses bug PIG-2641.
    https://issues.apache.org/jira/browse/PIG-2641
Diffs (updated)
-----

  src/org/apache/pig/builtin/JsonStorage.java 56086ff
  src/org/apache/pig/builtin/ToJson.java PRE-CREATION
  test/org/apache/pig/test/TestToJson.java PRE-CREATION
  test/org/apache/pig/test/data/jsonStorage1.tojson PRE-CREATION

Diff: https://reviews.apache.org/r/9481/diff/
Testing
-------

This works for me locally, and there is a working unit test.
Thanks,

Russell Jurney

+
Russell Jurney 2013-02-18, 23:16