|
Jean-Marc Spaggiari
2013-01-12, 22:28
Ted Yu
2013-01-12, 22:37
Jean-Marc Spaggiari
2013-01-12, 23:12
Matteo Bertozzi
2013-01-12, 23:14
Jean-Marc Spaggiari
2013-01-12, 23:20
lars hofhansl
2013-01-12, 23:27
Matteo Bertozzi
2013-01-12, 23:33
lars hofhansl
2013-01-12, 23:38
Jonathan Hsieh
2013-01-13, 16:43
Alejandro Abdelnur
2013-01-13, 20:10
Andrew Purtell
2013-01-13, 20:25
Enis Söztutar
2013-01-14, 20:02
Jean-Marc Spaggiari
2013-01-14, 20:17
Stack
2013-01-15, 04:37
Jonathan Hsieh
2013-01-15, 08:46
Nicolas Liochon
2013-01-15, 09:10
Todd Lipcon
2013-01-15, 17:04
Andrew Purtell
2013-01-15, 17:25
|
-
ProtoBuf generation?Jean-Marc Spaggiari 2013-01-12, 22:28
Hi,
I have update the Client.Proto file and would like to re-generate the classes. I tried mvn clean package -DskipTests and mvn clean install -DskipTests but the file is still not generated. Which command should I run to re-generate it? Thanks, JM
-
Re: ProtoBuf generation?Ted Yu 2013-01-12, 22:37
Under hbase-protocol module, run:
protoc -Isrc/main/protobuf --java_out=src/main/java <path-to-dor-proto-file> Cheers On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < [EMAIL PROTECTED]> wrote: > Hi, > > I have update the Client.Proto file and would like to re-generate the > classes. > > I tried mvn clean package -DskipTests and mvn clean install > -DskipTests but the file is still not generated. > > Which command should I run to re-generate it? > > Thanks, > > JM >
-
Re: ProtoBuf generation?Jean-Marc Spaggiari 2013-01-12, 23:12
Thanks for the prompt reply.
Should we add that into the HBase book where we explain how to build? Might be helpful? JM 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: > Under hbase-protocol module, run: > > protoc -Isrc/main/protobuf --java_out=src/main/java > <path-to-dor-proto-file> > > Cheers > > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < > [EMAIL PROTECTED]> wrote: > >> Hi, >> >> I have update the Client.Proto file and would like to re-generate the >> classes. >> >> I tried mvn clean package -DskipTests and mvn clean install >> -DskipTests but the file is still not generated. >> >> Which command should I run to re-generate it? >> >> Thanks, >> >> JM >> >
-
Re: ProtoBuf generation?Matteo Bertozzi 2013-01-12, 23:14
There's a README inside the hbase-protocol/src/main/protobuf directory
https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < [EMAIL PROTECTED]> wrote: > Thanks for the prompt reply. > > Should we add that into the HBase book where we explain how to build? > Might be helpful? > > JM > > 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: > > Under hbase-protocol module, run: > > > > protoc -Isrc/main/protobuf --java_out=src/main/java > > <path-to-dor-proto-file> > > > > Cheers > > > > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < > > [EMAIL PROTECTED]> wrote: > > > >> Hi, > >> > >> I have update the Client.Proto file and would like to re-generate the > >> classes. > >> > >> I tried mvn clean package -DskipTests and mvn clean install > >> -DskipTests but the file is still not generated. > >> > >> Which command should I run to re-generate it? > >> > >> Thanks, > >> > >> JM > >> > > >
-
Re: ProtoBuf generation?Jean-Marc Spaggiari 2013-01-12, 23:20
Thanks Matteo. I did not figured it. I tried the script into it and
it's working A1. I now need to understand how ProtoBuff is working ;) JM 2013/1/12, Matteo Bertozzi <[EMAIL PROTECTED]>: > There's a README inside the hbase-protocol/src/main/protobuf directory > https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt > > On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < > [EMAIL PROTECTED]> wrote: > >> Thanks for the prompt reply. >> >> Should we add that into the HBase book where we explain how to build? >> Might be helpful? >> >> JM >> >> 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: >> > Under hbase-protocol module, run: >> > >> > protoc -Isrc/main/protobuf --java_out=src/main/java >> > <path-to-dor-proto-file> >> > >> > Cheers >> > >> > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < >> > [EMAIL PROTECTED]> wrote: >> > >> >> Hi, >> >> >> >> I have update the Client.Proto file and would like to re-generate the >> >> classes. >> >> >> >> I tried mvn clean package -DskipTests and mvn clean install >> >> -DskipTests but the file is still not generated. >> >> >> >> Which command should I run to re-generate it? >> >> >> >> Thanks, >> >> >> >> JM >> >> >> > >> >
-
Re: ProtoBuf generation?lars hofhansl 2013-01-12, 23:27
Is there a reason why this in not integrated in the maven build?
If any of the .proto files changed shouldn't it automatically rebuild the generated classes? -- Lars ________________________________ From: Matteo Bertozzi <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Sent: Saturday, January 12, 2013 3:14 PM Subject: Re: ProtoBuf generation? There's a README inside the hbase-protocol/src/main/protobuf directory https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < [EMAIL PROTECTED]> wrote: > Thanks for the prompt reply. > > Should we add that into the HBase book where we explain how to build? > Might be helpful? > > JM > > 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: > > Under hbase-protocol module, run: > > > > protoc -Isrc/main/protobuf --java_out=src/main/java > > <path-to-dor-proto-file> > > > > Cheers > > > > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < > > [EMAIL PROTECTED]> wrote: > > > >> Hi, > >> > >> I have update the Client.Proto file and would like to re-generate the > >> classes. > >> > >> I tried mvn clean package -DskipTests and mvn clean install > >> -DskipTests but the file is still not generated. > >> > >> Which command should I run to re-generate it? > >> > >> Thanks, > >> > >> JM > >> > > >
-
Re: ProtoBuf generation?Matteo Bertozzi 2013-01-12, 23:33
I think that the idea was, the .proto files are not changing much overtime
so, we can commit the generated code, and avoid having the protobuf compiler installed. if we regenerated the protos everytime (mvn ...) we require protoc to be installed. Matteo On Sat, Jan 12, 2013 at 3:27 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: > Is there a reason why this in not integrated in the maven build? > If any of the .proto files changed shouldn't it automatically rebuild the > generated classes? > > > -- Lars > > > > ________________________________ > From: Matteo Bertozzi <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Sent: Saturday, January 12, 2013 3:14 PM > Subject: Re: ProtoBuf generation? > > There's a README inside the hbase-protocol/src/main/protobuf directory > > https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt > > On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < > [EMAIL PROTECTED]> wrote: > > > Thanks for the prompt reply. > > > > Should we add that into the HBase book where we explain how to build? > > Might be helpful? > > > > JM > > > > 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: > > > Under hbase-protocol module, run: > > > > > > protoc -Isrc/main/protobuf --java_out=src/main/java > > > <path-to-dor-proto-file> > > > > > > Cheers > > > > > > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < > > > [EMAIL PROTECTED]> wrote: > > > > > >> Hi, > > >> > > >> I have update the Client.Proto file and would like to re-generate the > > >> classes. > > >> > > >> I tried mvn clean package -DskipTests and mvn clean install > > >> -DskipTests but the file is still not generated. > > >> > > >> Which command should I run to re-generate it? > > >> > > >> Thanks, > > >> > > >> JM > > >> > > > > > >
-
Re: ProtoBuf generation?lars hofhansl 2013-01-12, 23:38
I see. Is there a way to only regenerate when they changed (ala make or ant)?
We do that sort of thing at Salesforce (not for protobufs, but other similar problems), that way you see what generated files your change affected and you can still check them in. -- Lars ________________________________ From: Matteo Bertozzi <[EMAIL PROTECTED]> To: [EMAIL PROTECTED]; lars hofhansl <[EMAIL PROTECTED]> Sent: Saturday, January 12, 2013 3:33 PM Subject: Re: ProtoBuf generation? I think that the idea was, the .proto files are not changing much overtime so, we can commit the generated code, and avoid having the protobuf compiler installed. if we regenerated the protos everytime (mvn ...) we require protoc to be installed. Matteo On Sat, Jan 12, 2013 at 3:27 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: Is there a reason why this in not integrated in the maven build? >If any of the .proto files changed shouldn't it automatically rebuild the generated classes? > > >-- Lars > > > >________________________________ > From: Matteo Bertozzi <[EMAIL PROTECTED]> >To: [EMAIL PROTECTED] >Sent: Saturday, January 12, 2013 3:14 PM >Subject: Re: ProtoBuf generation? > > >There's a README inside the hbase-protocol/src/main/protobuf directory >https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt > >On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < >[EMAIL PROTECTED]> wrote: > >> Thanks for the prompt reply. >> >> Should we add that into the HBase book where we explain how to build? >> Might be helpful? >> >> JM >> >> 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: >> > Under hbase-protocol module, run: >> > >> > protoc -Isrc/main/protobuf --java_out=src/main/java >> > <path-to-dor-proto-file> >> > >> > Cheers >> > >> > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < >> > [EMAIL PROTECTED]> wrote: >> > >> >> Hi, >> >> >> >> I have update the Client.Proto file and would like to re-generate the >> >> classes. >> >> >> >> I tried mvn clean package -DskipTests and mvn clean install >> >> -DskipTests but the file is still not generated. >> >> >> >> Which command should I run to re-generate it? >> >> >> >> Thanks, >> >> >> >> JM >> >> >> > >>
-
Re: ProtoBuf generation?Jonathan Hsieh 2013-01-13, 16:43
A week or so I added dev-support/build-proto.sh, a little script to
build protobuf stuff. https://issues.apache.org/jira/browse/HBASE-7490 I've been modifying protobuf a bit recently -- when you update run the script, protoc seems to generate exactly the same content unless you change proto source files. I think the argument for not having this run by default in the build is having it would require protoc installed on your machine to even build HBase. This also assumes all versions of protoc continues to generate the same code from different version (thrift's compiler was really annoying because every version generated code with a different api in every version). Jon. On Sat, Jan 12, 2013 at 3:38 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: > I see. Is there a way to only regenerate when they changed (ala make or ant)? > We do that sort of thing at Salesforce (not for protobufs, but other similar problems), that way you see what generated files your change affected and you can still check them in. > > -- Lars > > > > ________________________________ > From: Matteo Bertozzi <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED]; lars hofhansl <[EMAIL PROTECTED]> > Sent: Saturday, January 12, 2013 3:33 PM > Subject: Re: ProtoBuf generation? > > > I think that the idea was, the .proto files are not changing much overtime > so, we can commit the generated code, and avoid having the protobuf compiler installed. > if we regenerated the protos everytime (mvn ...) we require protoc to be installed. > > > Matteo > > On Sat, Jan 12, 2013 at 3:27 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: > > Is there a reason why this in not integrated in the maven build? >>If any of the .proto files changed shouldn't it automatically rebuild the generated classes? >> >> >>-- Lars >> >> >> >>________________________________ >> From: Matteo Bertozzi <[EMAIL PROTECTED]> >>To: [EMAIL PROTECTED] >>Sent: Saturday, January 12, 2013 3:14 PM >>Subject: Re: ProtoBuf generation? >> >> >>There's a README inside the hbase-protocol/src/main/protobuf directory >>https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt >> >>On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < >>[EMAIL PROTECTED]> wrote: >> >>> Thanks for the prompt reply. >>> >>> Should we add that into the HBase book where we explain how to build? >>> Might be helpful? >>> >>> JM >>> >>> 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: >>> > Under hbase-protocol module, run: >>> > >>> > protoc -Isrc/main/protobuf --java_out=src/main/java >>> > <path-to-dor-proto-file> >>> > >>> > Cheers >>> > >>> > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < >>> > [EMAIL PROTECTED]> wrote: >>> > >>> >> Hi, >>> >> >>> >> I have update the Client.Proto file and would like to re-generate the >>> >> classes. >>> >> >>> >> I tried mvn clean package -DskipTests and mvn clean install >>> >> -DskipTests but the file is still not generated. >>> >> >>> >> Which command should I run to re-generate it? >>> >> >>> >> Thanks, >>> >> >>> >> JM >>> >> >>> > >>> -- // Jonathan Hsieh (shay) // Software Engineer, Cloudera // [EMAIL PROTECTED]
-
Re: ProtoBuf generation?Alejandro Abdelnur 2013-01-13, 20:10
in Hadoop proto files are compiled on every build, thus we require protoc
install. currently we use the exec plugin to run protoc, but we may be switching soon to a maven plugin for protoc (still requires protoc installed). More info at https://issues.apache.org/jira/browse/HADOOP-9117 Thx On Sun, Jan 13, 2013 at 8:43 AM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote: > A week or so I added dev-support/build-proto.sh, a little script to > build protobuf stuff. > > https://issues.apache.org/jira/browse/HBASE-7490 > > I've been modifying protobuf a bit recently -- when you update run the > script, protoc seems to generate exactly the same content unless you > change proto source files. > > I think the argument for not having this run by default in the build > is having it would require protoc installed on your machine to even > build HBase. This also assumes all versions of protoc continues to > generate the same code from different version (thrift's compiler was > really annoying because every version generated code with a different > api in every version). > > Jon. > > On Sat, Jan 12, 2013 at 3:38 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: > > I see. Is there a way to only regenerate when they changed (ala make or > ant)? > > We do that sort of thing at Salesforce (not for protobufs, but other > similar problems), that way you see what generated files your change > affected and you can still check them in. > > > > -- Lars > > > > > > > > ________________________________ > > From: Matteo Bertozzi <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED]; lars hofhansl <[EMAIL PROTECTED]> > > Sent: Saturday, January 12, 2013 3:33 PM > > Subject: Re: ProtoBuf generation? > > > > > > I think that the idea was, the .proto files are not changing much > overtime > > so, we can commit the generated code, and avoid having the protobuf > compiler installed. > > if we regenerated the protos everytime (mvn ...) we require protoc to be > installed. > > > > > > Matteo > > > > On Sat, Jan 12, 2013 at 3:27 PM, lars hofhansl <[EMAIL PROTECTED]> wrote: > > > > Is there a reason why this in not integrated in the maven build? > >>If any of the .proto files changed shouldn't it automatically rebuild > the generated classes? > >> > >> > >>-- Lars > >> > >> > >> > >>________________________________ > >> From: Matteo Bertozzi <[EMAIL PROTECTED]> > >>To: [EMAIL PROTECTED] > >>Sent: Saturday, January 12, 2013 3:14 PM > >>Subject: Re: ProtoBuf generation? > >> > >> > >>There's a README inside the hbase-protocol/src/main/protobuf directory > >> > https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/protobuf/README.txt > >> > >>On Sat, Jan 12, 2013 at 3:12 PM, Jean-Marc Spaggiari < > >>[EMAIL PROTECTED]> wrote: > >> > >>> Thanks for the prompt reply. > >>> > >>> Should we add that into the HBase book where we explain how to build? > >>> Might be helpful? > >>> > >>> JM > >>> > >>> 2013/1/12, Ted Yu <[EMAIL PROTECTED]>: > >>> > Under hbase-protocol module, run: > >>> > > >>> > protoc -Isrc/main/protobuf --java_out=src/main/java > >>> > <path-to-dor-proto-file> > >>> > > >>> > Cheers > >>> > > >>> > On Sat, Jan 12, 2013 at 2:28 PM, Jean-Marc Spaggiari < > >>> > [EMAIL PROTECTED]> wrote: > >>> > > >>> >> Hi, > >>> >> > >>> >> I have update the Client.Proto file and would like to re-generate > the > >>> >> classes. > >>> >> > >>> >> I tried mvn clean package -DskipTests and mvn clean install > >>> >> -DskipTests but the file is still not generated. > >>> >> > >>> >> Which command should I run to re-generate it? > >>> >> > >>> >> Thanks, > >>> >> > >>> >> JM > >>> >> > >>> > > >>> > > > > -- > // Jonathan Hsieh (shay) > // Software Engineer, Cloudera > // [EMAIL PROTECTED] > -- Alejandro
-
Re: ProtoBuf generation?Andrew Purtell 2013-01-13, 20:25
Hadoop 2 requires protoc for building as Alejandro mentions, and an
optimistic read of the future says we will eventually move on from Hadoop 1. protoc is not difficult to download, configure, compile, and install -- and some distros have packages for it. I may have been bitten ~10 times in 2012 for lacking it here and there but that would not be the typical experience. I was also bitten by needing a recent enough version of Maven. I see lacking protoc as the same type of build requirement inconvenience. Seems reasonable to adopt a maven plugin to invoke protoc and a binding of this to our build targets. On Sun, Jan 13, 2013 at 12:10 PM, Alejandro Abdelnur <[EMAIL PROTECTED]>wrote: > in Hadoop proto files are compiled on every build, thus we require protoc > install. > -- Best regards, - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
-
Re: ProtoBuf generation?Enis Söztutar 2013-01-14, 20:02
I think the idea was to make it easier for the average developer to get
hbase building without the hassle. The only downside is that we have to commit the generated code. I've opened https://issues.apache.org/jira/browse/HBASE-7557 as a critical. Enis On Sun, Jan 13, 2013 at 12:25 PM, Andrew Purtell <[EMAIL PROTECTED]>wrote: > 012 for lacking it here and there but that would not be the typical > experience. I was also bitten by needing a recent en >
-
Re: ProtoBuf generation?Jean-Marc Spaggiari 2013-01-14, 20:17
protoc is pretty easy to install on all the systems. It took me few
seconds to install it. So if someone try to build and the build is failing because protoc is missing, then just install it? It's like if javac or mvn is missing. It can be considered as a critical tool to allo HBase build to succeed? JM 2013/1/14, Enis Söztutar <[EMAIL PROTECTED]>: > I think the idea was to make it easier for the average developer to get > hbase building without the hassle. The only downside is that we have to > commit the generated code. > > I've opened https://issues.apache.org/jira/browse/HBASE-7557 as a critical. > > Enis > > On Sun, Jan 13, 2013 at 12:25 PM, Andrew Purtell > <[EMAIL PROTECTED]>wrote: > >> 012 for lacking it here and there but that would not be the typical >> experience. I was also bitten by needing a recent en >> >
-
Re: ProtoBuf generation?Stack 2013-01-15, 04:37
My thinking was that its rare someone is messing w/ protobufs so why burden
all builders w/ having to install protoc? St.Ack On Mon, Jan 14, 2013 at 12:02 PM, Enis Söztutar <[EMAIL PROTECTED]> wrote: > I think the idea was to make it easier for the average developer to get > hbase building without the hassle. The only downside is that we have to > commit the generated code. > > I've opened https://issues.apache.org/jira/browse/HBASE-7557 as a > critical. > > Enis > > On Sun, Jan 13, 2013 at 12:25 PM, Andrew Purtell <[EMAIL PROTECTED] > >wrote: > > > 012 for lacking it here and there but that would not be the typical > > experience. I was also bitten by needing a recent en > > >
-
Re: ProtoBuf generation?Jonathan Hsieh 2013-01-15, 08:46
I tend to agree with this -- there is no guarantee that future
versions of this will not break compatiblity, (thrift did this multiple times), yeah, modifying protobuf stuff is rare. I'd be happy if we detected if protoc was present, use it if it was but also allow the build if it isn't by using the committed generated code. Jon. On Mon, Jan 14, 2013 at 8:37 PM, Stack <[EMAIL PROTECTED]> wrote: > My thinking was that its rare someone is messing w/ protobufs so why burden > all builders w/ having to install protoc? > St.Ack > > > On Mon, Jan 14, 2013 at 12:02 PM, Enis Söztutar <[EMAIL PROTECTED]> wrote: > >> I think the idea was to make it easier for the average developer to get >> hbase building without the hassle. The only downside is that we have to >> commit the generated code. >> >> I've opened https://issues.apache.org/jira/browse/HBASE-7557 as a >> critical. >> >> Enis >> >> On Sun, Jan 13, 2013 at 12:25 PM, Andrew Purtell <[EMAIL PROTECTED] >> >wrote: >> >> > 012 for lacking it here and there but that would not be the typical >> > experience. I was also bitten by needing a recent en >> > >> -- // Jonathan Hsieh (shay) // Software Engineer, Cloudera // [EMAIL PROTECTED]
-
Re: ProtoBuf generation?Nicolas Liochon 2013-01-15, 09:10
+1. I prefer to know exactly what I do rather then depending on the default
version that will vary from a system to another. And we may depend on multiple version of protoc in the future (one for 0.96, on for 0.98; one for 0.99 and so on). On Tue, Jan 15, 2013 at 9:46 AM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote: > I tend to agree with this -- there is no guarantee that future > versions of this will not break compatiblity, (thrift did this > multiple times), yeah, modifying protobuf stuff is rare. > > I'd be happy if we detected if protoc was present, use it if it was > but also allow the build if it isn't by using the committed generated > code. > > Jon. > > On Mon, Jan 14, 2013 at 8:37 PM, Stack <[EMAIL PROTECTED]> wrote: > > My thinking was that its rare someone is messing w/ protobufs so why > burden > > all builders w/ having to install protoc? > > St.Ack > > > > > > On Mon, Jan 14, 2013 at 12:02 PM, Enis Söztutar <[EMAIL PROTECTED]> > wrote: > > > >> I think the idea was to make it easier for the average developer to get > >> hbase building without the hassle. The only downside is that we have to > >> commit the generated code. > >> > >> I've opened https://issues.apache.org/jira/browse/HBASE-7557 as a > >> critical. > >> > >> Enis > >> > >> On Sun, Jan 13, 2013 at 12:25 PM, Andrew Purtell <[EMAIL PROTECTED] > >> >wrote: > >> > >> > 012 for lacking it here and there but that would not be the typical > >> > experience. I was also bitten by needing a recent en > >> > > >> > > > > -- > // Jonathan Hsieh (shay) > // Software Engineer, Cloudera > // [EMAIL PROTECTED] >
-
Re: ProtoBuf generation?Todd Lipcon 2013-01-15, 17:04
On Tue, Jan 15, 2013 at 12:46 AM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:
> I tend to agree with this -- there is no guarantee that future > versions of this will not break compatiblity, (thrift did this > multiple times), yeah, modifying protobuf stuff is rare. > FWIW, old versions of protoc did generate code which isn't compatible with new versions of the library (similar to Thrift). -Todd -- Todd Lipcon Software Engineer, Cloudera
-
Re: ProtoBuf generation?Andrew Purtell 2013-01-15, 17:25
I suppose I come at this from the point of view of "why wouldn't I also be
compiling Hadoop at the same time?". I will withdraw my earlier comment because I'm not able to judge how frequently someone building HBase would also want to build Hadoop. We don't need to repeat the sins of other projects of course but I'm curious why protoc is required for building HDFS, etc., when these same arguments would seem to apply there equally. On Tue, Jan 15, 2013 at 9:04 AM, Todd Lipcon <[EMAIL PROTECTED]> wrote: > On Tue, Jan 15, 2013 at 12:46 AM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote: > > > I tend to agree with this -- there is no guarantee that future > > versions of this will not break compatiblity, (thrift did this > > multiple times), yeah, modifying protobuf stuff is rare. > > > > FWIW, old versions of protoc did generate code which isn't compatible with > new versions of the library (similar to Thrift). > > -Todd > -- > Todd Lipcon > Software Engineer, Cloudera > -- Best regards, - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White) |