Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 14779: Review of SQOOP-435


Copy link to this message
-
Re: Review Request 14779: Review of SQOOP-435


> On Oct. 23, 2013, 2:20 a.m., James Anderson wrote:
> > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java, line 104
> > <https://reviews.apache.org/r/14779/diff/1/?file=368513#file368513line104>
> >
> >     In an updated patch, I've modified the code such that it follows the same pattern as ClassWriter/CompilationManager.  It will initially write the *.avsc file to the JAR output directory, and then attempt to move the file to the code output directory (CWD).  I thought this was a safe approach just in case there comes a point where having an updated *.avsc file alongside an updated *.java/*.jar file in the JAR output directory is important to someone's Sqoop workflow.  The *.avsc file in the code output directory will not be overwritten.

Sounds good, thank you!
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14779/#review27358
-----------------------------------------------------------
On Oct. 23, 2013, 2:22 a.m., James Anderson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14779/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 2:22 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-435
>     https://issues.apache.org/jira/browse/SQOOP-435
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Automatically generate an Avro schema file (*.avsc) in the JAR output directory when --as-avrodatafile is specified.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 5afd90c
>   src/test/com/cloudera/sqoop/TestAvroImport.java 34a7d41
>
> Diff: https://reviews.apache.org/r/14779/diff/
>
>
> Testing
> -------
>
> - Compared contents of *.avsc file against output from avro-tools getschema operation.
> - Created an external Hive table with AvroSerDe, pointing avro.schema.url to a copy of the schema indexed in ElasticSearch.
>
>
> Thanks,
>
> James Anderson
>
>