Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown


+
Israel Ekpo 2013-04-11, 04:44
+
Mike Percy 2013-04-16, 07:10
+
Israel Ekpo 2013-04-16, 15:00
Copy link to this message
-
Re: Review Request: FLUME-1940, FLUME-1957 - Logging Snapshots of Flume Metrics on Shutdown
Israel Ekpo 2013-04-16, 14:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10416/#review19250
-----------------------------------------------------------
I think instead of adding the start and stop times for the components in the map I will just dump them separately and then proceed with sorting the orignal keys in the map only.

I will also add a check to make sure the value exists as you recommended.

Thanks for the feedback.

- Israel Ekpo
On April 11, 2013, 4:44 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10416/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 4:44 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logging Metrics from the stop() method for the following components: ChannelCounter, ChannelProcessorCounter, SinkCounter, SinkProcessorCounter, SourceCounter
>
>
> This addresses bugs FLUME-1940 and FLUME-1957.
>     https://issues.apache.org/jira/browse/FLUME-1940
>     https://issues.apache.org/jira/browse/FLUME-1957
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java 502fe9e
>
> Diff: https://reviews.apache.org/r/10416/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Israel Ekpo
>
>

+
Israel Ekpo 2013-04-23, 04:21
+
Israel Ekpo 2013-04-24, 11:16
+
Mike Percy 2013-04-26, 08:52