Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1699. Make the rename of the meta file platform neutral


Copy link to this message
-
Re: Review Request: FLUME-1699. Make the rename of the meta file platform neutral
Brock Noland 2012-11-19, 19:47

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8087/#review13582
-----------------------------------------------------------

flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java
<https://reviews.apache.org/r/8087/#comment29149>

    I think this will be better, because if these renames fail an error will be thrown below because the VERSION header will be incorrect. However, it seems at this point we know that the .meta file should exist since there is a .meta.tmp or .meta.old so these renames failing should be a cause to halt and inform the user?  At present the error message will be kind of confusion since if this logic is correct that error will only be seen if the file is corrupt.
- Brock Noland
On Nov. 19, 2012, 7:41 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8087/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:41 p.m.)
>
>
> Review request for Flume and Brock Noland.
>
>
> Description
> -------
>
> If atomic rename fails, rename the current meta file to old, rename tmp to meta and then delete old.
>
>
> This addresses bug FLUME-1699.
>     https://issues.apache.org/jira/browse/FLUME-1699
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 82e14b0
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java f768d23
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 6b0eeb3
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 4b69698
>
> Diff: https://reviews.apache.org/r/8087/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Hari Shreedharan
>
>