Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Adds an abort validation handler which terminates the processing of import/export jobs.


+
Seetharam Venkatesh 2013-04-03, 10:53
Copy link to this message
-
Re: Review Request: Adds an abort validation handler which terminates the processing of import/export jobs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10252/#review18715
-----------------------------------------------------------

Ship it!
Thank you for your time and effort sir!

- Jarek Cecho
On April 3, 2013, 10:53 a.m., Seetharam Venkatesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10252/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 10:53 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Validation of the data copied, either import or export, is implemented today by comparing the row counts from the source and the target post copy. This issue adds a handler that aborts the processing notifying the user of the anomaly.
>
> Makes this the default implementation.
>
>
> This addresses bug SQOOP-916.
>     https://issues.apache.org/jira/browse/SQOOP-916
>
>
> Diffs
> -----
>
>   src/docs/user/validation.txt f28b420
>   src/java/org/apache/sqoop/SqoopOptions.java 906542b
>   src/java/org/apache/sqoop/validation/AbortOnFailureHandler.java PRE-CREATION
>   src/java/org/apache/sqoop/validation/LogOnFailureHandler.java 3ded6ad
>   src/java/org/apache/sqoop/validation/RowCountValidator.java 2896192
>   src/java/org/apache/sqoop/validation/ValidationException.java 0c10241
>   src/test/org/apache/sqoop/validation/AbortOnFailureHandlerTest.java PRE-CREATION
>   src/test/org/apache/sqoop/validation/AbsoluteValidationThresholdTest.java PRE-CREATION
>   src/test/org/apache/sqoop/validation/RowCountValidatorImportTest.java a53e281
>
> Diff: https://reviews.apache.org/r/10252/diff/
>
>
> Testing
> -------
>
> Yes. Unit tests are added to test the new functionality.
>
>
> Thanks,
>
> Seetharam Venkatesh
>
>