Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs


Copy link to this message
-
Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs
Mengwei Ding 2013-07-16, 22:46

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12593/
-----------------------------------------------------------

Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-1141
    https://issues.apache.org/jira/browse/SQOOP-1141
Repository: sqoop-sqoop2
Description
-------

commit 65c0b55f6630c8dfec06b5fb150e5dcc07153e33
Author: Mengwei Ding <[EMAIL PROTECTED]>
Date:   Tue Jul 16 10:41:12 2013 -0700

    SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

:100644 100644 b7b0436... 999790d... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:000000 100644 0000000... 5cbd6db... A client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java
:000000 100644 0000000... d997267... A client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
:000000 100644 0000000... ef58845... A client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
:000000 100644 0000000... 8a2c1c7... A client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java
:000000 100644 0000000... e722991... A client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
:000000 100644 0000000... 4adaeca... A client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java
:100644 100644 32bca71... 94f92b3... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 97a240b... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 aa87f20... f4ea3be... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:100644 100644 5537a8e... 1a8f963... M client/src/main/resources/client-resource.properties
:100644 100644 b4e986a... a014ddd... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... 4685797... M common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 98768d6... ba12b39... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 5524983... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 4277311... f7a6b67... M core/src/main/java/org/apache/sqoop/framework/FrameworkError.java
:100644 100644 2d37020... e68147f... M core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 f717abf... 27f7358... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 49bf607... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... 8b3b6a9... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436
  client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java PRE-CREATION
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7
  client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java aa87f20
  client/src/main/resources/client-resource.properties 5537a8e
  common/src/main/java/org/apache/sqoop/json/ConnectionBean.java b4e986a
  common/src/main/java/org/apache/sqoop/json/JobBean.java a830646
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 98768d6
  common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 137e71c
  core/src/main/java/org/apache/sqoop/framework/FrameworkError.java 4277311
  core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 68cb1c0
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc

Diff: https://reviews.apache.org/r/12593/diff/
Testing

Did some manual tests to check whether job could be started if either job or connection has been disabled.
Thanks,

Mengwei Ding