Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-470 Create tests for blob support for Avro import


+
Cheolsoo Park 2012-03-28, 02:43
Copy link to this message
-
Re: Review Request: SQOOP-470 Create tests for blob support for Avro import
Bilung Lee 2012-03-29, 22:04

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4527/#review6548
-----------------------------------------------------------
Look good overall.  It would be better if you could also add some to test out the area of compression.

- Bilung
On 2012-03-28 02:43:38, Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4527/
> -----------------------------------------------------------
>
> (Updated 2012-03-28 02:43:38)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> Add Avro blob import tests as part of thrid party test suite since Hsqldb does not support BLOB/CLOB type.
>
> The changes include:
>
> - abstract LobAvroImportTestCase class
>   1) testBlobAvroImportInline: test inline import
>   2) testBlobAvroImportExternal: test external file import
>   3) testBlobAvroImportMultiCols: test multiple columns import
>
> - OracleLobAvroImportTest class
> - MySQLLobAvroImportTest class
>
>
> This addresses bug SQOOP-470.
>     https://issues.apache.org/jira/browse/SQOOP-470
>
>
> Diffs
> -----
>
>   ./src/test/com/cloudera/sqoop/manager/MySQLLobAvroImportTest.java PRE-CREATION
>   ./src/test/com/cloudera/sqoop/manager/OracleLobAvroImportTest.java PRE-CREATION
>   ./src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4527/diff
>
>
> Testing
> -------
>
> Tested with Oracle XE 10g and MySQL 5.1
>
> Ran ant test
> Ran ant test -Dthirdparty=true
> Ran ant checkstyle
>
>
> Thanks,
>
> Cheolsoo
>
>

+
Cheolsoo Park 2012-03-29, 23:15
+
Cheolsoo Park 2012-04-04, 02:15
+
Bilung Lee 2012-04-04, 20:44
+
Cheolsoo Park 2012-04-04, 01:55
+
Bilung Lee 2012-04-06, 18:15