Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Accumulo >> mail # dev >> Review Request: Patch submitted by Chris McCubbin to add thrift proxy to Accumulo


+
keith@... 2012-11-07, 20:33
+
keith@... 2012-11-07, 21:14
+
keith@... 2012-11-07, 21:55
+
Chris McCubbin 2012-11-07, 21:40
Copy link to this message
-
Re: Review Request: Patch submitted by Chris McCubbin to add thrift proxy to Accumulo


> On Nov. 7, 2012, 9:14 p.m., kturner wrote:
> > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java, line 567
> > <https://reviews.apache.org/r/7936/diff/1/?file=186420#file186420line567>
> >
> >     would probably be more efficient to get the scanner once from the iteratorMap, rather than doing a lookup in the map for each loop iteration

We just discussed a different design where the scanner_next_k is the "base" method and scanner_next calls scanner_next_k with k=1. This way around (while a little unintuitive) may actually result in the best overall performance since we are almost always going to call next_k when performance matters, since it maximizes scanner reuse and minimizes function calls in the server.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7936/#review13220
-----------------------------------------------------------
On Nov. 7, 2012, 8:33 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7936/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2012, 8:33 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> Patch submitted by Chris McCubbin to add thrift proxy to Accumulo
>
>
> This addresses bug ACCUMULO-482.
>     https://issues.apache.org/jira/browse/ACCUMULO-482
>
>
> Diffs
> -----
>
>   /trunk/pom.xml 1406772
>   /trunk/proxy/README PRE-CREATION
>   /trunk/proxy/examples/python/README PRE-CREATION
>   /trunk/proxy/examples/python/TestClient.py PRE-CREATION
>   /trunk/proxy/examples/python/data/__init__.py PRE-CREATION
>   /trunk/proxy/examples/python/data/constants.py PRE-CREATION
>   /trunk/proxy/examples/python/data/ttypes.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION
>   /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION
>   /trunk/proxy/examples/ruby/README PRE-CREATION
>   /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/data_constants.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/data_types.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION
>   /trunk/proxy/pom.xml PRE-CREATION
>   /trunk/proxy/proxy.properties PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloProxy.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloSecurityException.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/IOException.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/KeyValueAndPeek.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/NoMoreEntriesException.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyIteratorSetting.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxySystemPermission.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyTablePermission.java PRE-CREATION
+
keith@... 2012-11-07, 21:41
+
Chris McCubbin 2012-11-07, 21:55
+
keith@... 2012-11-07, 22:05
+
keith@... 2012-11-07, 21:44