A number of C patches have been submitted to Avro recently.

http://s.apache.org/uo

Can someone more familiar with the C implementation than I am please
review these?  If no one else does first, I'll try to later this week.

My approach would be to check that:
  0. They sound and look reasonable.
  1. They include a test.
  2. Tests pass after they are applied.
If these are true then I'll commit them.

Others would probably be much better at (0) than I am.

As a project we should review patches promptly.

Doug

> A number of C patches have been submitted to Avro recently.
>
> http://s.apache.org/uo
>
> Can someone more familiar with the C implementation than I am please
> review these?  If no one else does first, I'll try to later this week.
>
> My approach would be to check that:
>  0. They sound and look reasonable.
>  1. They include a test.
>  2. Tests pass after they are applied.
> If these are true then I'll commit them.
>
> Others would probably be much better at (0) than I am.
>
> As a project we should review patches promptly.

My apologies for not getting to them sooner.  I'm taking a look at them now.

cheers
–doug

On 12/13/2011 11:04 AM, Douglas Creager wrote:
> I'm taking a look at them now.

Thanks!

Doug