Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 15961: SQOOP-1240


Copy link to this message
-
Re: Review Request 15961: SQOOP-1240

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15961/#review29766
-----------------------------------------------------------
Hi James,
thank you very much for working on this patch! I do have one high level question below. Considering that there is no attached test case, would you mind describing how you've verified the fix?
src/java/org/apache/sqoop/tool/JobTool.java
<https://reviews.apache.org/r/15961/#comment57246>

    Will this work properly when user will try to override the extra arguments on the command line, right? For example:
    
    sqoop job --exec XXX -- --table X -- --table-hints WITH_LOCK
Jarcec

- Jarek Cecho
On Dec. 3, 2013, 1:44 p.m., James Anderson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15961/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 1:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1240
>     https://issues.apache.org/jira/browse/SQOOP-1240
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Ensure that extra arguments retrieved from the metastore are passed to the child tool being executed.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/tool/JobTool.java 4359058
>
> Diff: https://reviews.apache.org/r/15961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Anderson
>
>