Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Review Request: PIG-3269 In operator support


+
Cheolsoo Park 2013-04-08, 14:02
Copy link to this message
-
Re: Review Request: PIG-3269 In operator support
Aniket Mokashi 2013-04-09, 20:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10337/#review18887
-----------------------------------------------------------

src/org/apache/pig/parser/QueryParser.g
<https://reviews.apache.org/r/10337/#comment39348>

    You don't need the IN token here as QueryLexer has it.

src/org/apache/pig/parser/QueryParser.g
<https://reviews.apache.org/r/10337/#comment39349>

    You can probably remove IN_EVAL token completely.
- Aniket Mokashi
On April 8, 2013, 2:02 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10337/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 2:02 p.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> Add SQL IN operator to Pig. Please see:
> https://issues.apache.org/jira/browse/PIG-3269
>
>
> This addresses bug PIG-3269.
>     https://issues.apache.org/jira/browse/PIG-3269
>
>
> Diffs
> -----
>
>   src/org/apache/pig/builtin/IN.java PRE-CREATION
>   src/org/apache/pig/parser/AstPrinter.g 5d83bea
>   src/org/apache/pig/parser/AstValidator.g b85e238
>   src/org/apache/pig/parser/LogicalPlanGenerator.g 26f13f6
>   src/org/apache/pig/parser/QueryLexer.g c7f9fdd
>   src/org/apache/pig/parser/QueryParser.g 538621b
>   test/commit-tests 5081fbc
>   test/org/apache/pig/builtin/TestInUdf.java PRE-CREATION
>   test/org/apache/pig/test/TestIn.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10337/diff/
>
>
> Testing
> -------
>
> Added two new test suites:
> - TestIn.java
> - TestInUdf.java
>
> Also ran ant test-commit.
>
>
> Thanks,
>
> Cheolsoo Park
>
>

+
Cheolsoo Park 2013-04-09, 21:24
+
Aniket Mokashi 2013-04-09, 21:35