Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-412: Port files org.apache.hadoop.mapreduce.lib.{db, input}.* from CDH3/Hadoop-0.21 to sqoop


Copy link to this message
-
Re: Review Request: SQOOP-412: Port files org.apache.hadoop.mapreduce.lib.{db, input}.* from CDH3/Hadoop-0.21 to sqoop

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3272/#review4054
-----------------------------------------------------------

Ship it!
+1

Did more sanity testing. All looks good.

- Arvind
On 2011-12-21 06:26:13, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3272/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 06:26:13)
>
>
> Review request for Sqoop and Arvind Prabhakar.
>
>
> Summary
> -------
>
> I've copypasted all four files from CHD3 release and put them into sqoop mapreduce module (I altered files to conform our checkstyle policy). I've also changed all references in sqoop to use this new four classes instead of the default ones present in hadoop-0.21.
>
>
> This addresses bug SQOOP-413.
>     https://issues.apache.org/jira/browse/SQOOP-413
>
>
> Diffs
> -----
>
>   /src/java/com/cloudera/sqoop/mapreduce/CombineShimRecordReader.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1221303
>   /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1221303
>   /src/java/org/apache/sqoop/config/ConfigurationHelper.java 1221303
>   /src/java/org/apache/sqoop/lib/SqoopRecord.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/CombineFileRecordReader.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/CombineFileSplit.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/CombineShimRecordReader.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/DBWritable.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/ExportInputFormat.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1221303
>   /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1221303
>   /src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1221303
>
> Diff: https://reviews.apache.org/r/3272/diff
>
>
> Testing
> -------
>
> I've tested with both -Dhadopoversion=20 and -Dhadoopversion=23.
>
>
> Thanks,
>
> Jarek
>
>