Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: svn commit: r1206698 - in /incubator/sqoop/trunk: pom.xml src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java


Copy link to this message
-
Re: svn commit: r1206698 - in /incubator/sqoop/trunk: pom.xml src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
IMHO I think it will be better and more maintenable to use filtering
stuff from maven and generate a .properties file with the needed infos
instead of modifying a .java file.
The SqoopVersion class could read this .properties file.

And will make the build pass on windauze by example :-)

2011/11/27  <[EMAIL PROTECTED]>:
> Author: jarcec
> Date: Sun Nov 27 11:12:37 2011
> New Revision: 1206698
>
> URL: http://svn.apache.org/viewvc?rev=1206698&view=rev
> Log:
> SQOOP-392. Build using maven is broken due to missing class generated by script write-version-info.sh
>
> (Arvind Prabhakar via Jarek Jarcec Cecho)
>
>
> Modified:
>    incubator/sqoop/trunk/pom.xml
>    incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
>
> Modified: incubator/sqoop/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/sqoop/trunk/pom.xml?rev=1206698&r1=1206697&r2=1206698&view=diff
> =============================================================================> --- incubator/sqoop/trunk/pom.xml (original)
> +++ incubator/sqoop/trunk/pom.xml Sun Nov 27 11:12:37 2011
> @@ -261,12 +261,23 @@ limitations under the License.
>   </dependencies>
>
>   <build>
> +    <scriptSourceDirectory>src/scripts</scriptSourceDirectory>
>     <sourceDirectory>src/java</sourceDirectory>
>     <testSourceDirectory>src/test</testSourceDirectory>
>     <pluginManagement>
>       <plugins>
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
> +          <artifactId>maven-antrun-plugin</artifactId>
> +          <version>1.7</version>
> +        </plugin>
> +        <plugin>
> +          <groupId>org.codehaus.mojo</groupId>
> +          <artifactId>build-helper-maven-plugin</artifactId>
> +          <version>1.7</version>
> +        </plugin>
> +        <plugin>
> +          <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-clean-plugin</artifactId>
>           <version>2.4.1</version>
>         </plugin>
> @@ -300,6 +311,47 @@ limitations under the License.
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
> +        <artifactId>maven-antrun-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <id>generate-version-tool</id>
> +            <phase>generate-sources</phase>
> +            <goals><goal>run</goal></goals>
> +            <configuration>
> +              <target>
> +                <echo>Generating version tool</echo>
> +                <mkdir dir="${basedir}/target/generated-sources"/>
> +                <exec executable="${basedir}/src/scripts/write-version-info.sh"
> +                      dir="${basedir}" failonerror="true">
> +                  <arg value="${basedir}/target/generated-sources"/>
> +                  <arg value="${version}" />
> +                  <arg value="${gitHash}" />
> +                </exec>
> +              </target>
> +            </configuration>
> +          </execution>
> +        </executions>
> +      </plugin>
> +      <plugin>
> +        <groupId>org.codehaus.mojo</groupId>
> +        <artifactId>build-helper-maven-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <id>add-generated-sources</id>
> +            <phase>generate-sources</phase>
> +            <goals>
> +              <goal>add-source</goal>
> +            </goals>
> +            <configuration>
> +              <sources>
> +                <source>${basedir}/target/generated-sources/src</source>
> +              </sources>
> +            </configuration>
> +          </execution>
> +        </executions>
> +      </plugin>
> +      <plugin>
> +        <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-surefire-plugin</artifactId>
>         <configuration>
>           <systemPropertyVariables>
>
> Modified: incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
> URL: http://svn.apache.org/viewvc/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java?rev=1206698&r1=1206697&r2=1206698&view=diff

Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB