Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-858 Sqoop2: Add validation messages on form level


Copy link to this message
-
Review Request: SQOOP-858 Sqoop2: Add validation messages on form level
Jarek Cecho 2013-02-03, 19:36

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've extended the system to support validations on form level.
This addresses bug SQOOP-858.
    https://issues.apache.org/jira/browse/SQOOP-858
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
  common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
  common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
  connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d

Diff: https://reviews.apache.org/r/9279/diff/
Testing
-------

Unit tests seems to be passing and I've tried several scenarios on real cluster.
Thanks,

Jarek Cecho