Hi all,
 I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
Friday night fixing bugs :).

*** Please download, test and VOTE before the
*** vote closes 5pm PT on Saturday, Nov12***

http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/

Should we release this?

Please try out the release ASAP. Would appreciate early feedback.

thanks
mahadev

-1  RAT ("ant releaseaudit) is reporting that winconfig.h is missing a
license. Do we know where this file came from?

winstdint.h is getting flagged, but afaict it's ok - has a reasonable
license, which is noted in the NOTICE file (under src/c)
(build.xml should probably be updated to exclude winstdint.h ?)

otw things look good so far; signing/checksums, ran "ant test" and it passed.

I need to do more b/w compatibility testing and such but otw it seems
very close.

Patrick

On Sat, Nov 5, 2011 at 5:23 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Hi all,
>  I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
> Friday night fixing bugs :).
>
> *** Please download, test and VOTE before the
> *** vote closes 5pm PT on Saturday, Nov12***
>
> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/
>
> Should we release this?
>
> Please try out the release ASAP. Would appreciate early feedback.
>
> thanks
> mahadev
>

Dheeraj, this came in from you probably. Can you check that we can put
this into the Apache License or what license it needs?

C

On Mon, Nov 7, 2011 at 7:35 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> -1  RAT ("ant releaseaudit) is reporting that winconfig.h is missing a
> license. Do we know where this file came from?
>
> winstdint.h is getting flagged, but afaict it's ok - has a reasonable
> license, which is noted in the NOTICE file (under src/c)
> (build.xml should probably be updated to exclude winstdint.h ?)
>
> otw things look good so far; signing/checksums, ran "ant test" and it passed.
>
> I need to do more b/w compatibility testing and such but otw it seems
> very close.
>
> Patrick
>
> On Sat, Nov 5, 2011 at 5:23 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Hi all,
>>  I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
>> Friday night fixing bugs :).
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 5pm PT on Saturday, Nov12***
>>
>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/
>>
>> Should we release this?
>>
>> Please try out the release ASAP. Would appreciate early feedback.
>>
>> thanks
>> mahadev
>>
>

winconfig.h was originally taken from : https://issues.apache.org/jira/browse/ZOOKEEPER-859 (config.h)
And this is just the modification of the auto generated config.h file to include windows specific stuff. So I guess whatever license holds for config.h will hold for winconfig.h
The Goldman Sachs Group, Inc. All rights reserved.
See http://www.gs.com/disclaimer/global_email for important risk disclosures, conflicts of interest and other terms and conditions relating to this e-mail and your reliance on information contained in it.  This message may contain confidential or privileged information.  If you are not the intended recipient, please advise us immediately and delete this message.  See http://www.gs.com/disclaimer/email for further information on confidentiality and the risks of non-secure electronic communication.  If you cannot access these links, please notify us by reply message and we will send the contents to you. 
-----Original Message-----
From: Camille Fournier [mailto:[EMAIL PROTECTED]]
Sent: Monday, November 07, 2011 7:45 PM
To: [EMAIL PROTECTED]; Agrawal, Dheeraj [Tech]
Cc: Mahadev Konar
Subject: Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 1)

Dheeraj, this came in from you probably. Can you check that we can put
this into the Apache License or what license it needs?

C

On Mon, Nov 7, 2011 at 7:35 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> -1  RAT ("ant releaseaudit) is reporting that winconfig.h is missing a
> license. Do we know where this file came from?
>
> winstdint.h is getting flagged, but afaict it's ok - has a reasonable
> license, which is noted in the NOTICE file (under src/c)
> (build.xml should probably be updated to exclude winstdint.h ?)
>
> otw things look good so far; signing/checksums, ran "ant test" and it passed.
>
> I need to do more b/w compatibility testing and such but otw it seems
> very close.
>
> Patrick
>
> On Sat, Nov 5, 2011 at 5:23 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Hi all,
>>  I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
>> Friday night fixing bugs :).
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 5pm PT on Saturday, Nov12***
>>
>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/
>>
>> Should we release this?
>>
>> Please try out the release ASAP. Would appreciate early feedback.
>>
>> thanks
>> mahadev
>>
>

I checked check sums.  Ran the included shell and played around with files.
 Then I recompiled from the included sources and ran tests which succeeded.
 This was all on a Mac with java version 1.6.0_26.

On Mon, Nov 7, 2011 at 7:35 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> -1  RAT ("ant releaseaudit) is reporting that winconfig.h is missing a
> license. Do we know where this file came from?
>
> winstdint.h is getting flagged, but afaict it's ok - has a reasonable
> license, which is noted in the NOTICE file (under src/c)
> (build.xml should probably be updated to exclude winstdint.h ?)
>
> otw things look good so far; signing/checksums, ran "ant test" and it
> passed.
>
> I need to do more b/w compatibility testing and such but otw it seems
> very close.
>
> Patrick
>
> On Sat, Nov 5, 2011 at 5:23 PM, Mahadev Konar <[EMAIL PROTECTED]>
> wrote:
> > Hi all,
> >  I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
> > Friday night fixing bugs :).
> >
> > *** Please download, test and VOTE before the
> > *** vote closes 5pm PT on Saturday, Nov12***
> >
> > http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/
> >
> > Should we release this?
> >
> > Please try out the release ASAP. Would appreciate early feedback.
> >
> > thanks
> > mahadev
> >
>

Datapoint:

I've updated from 3.3.3 to this RC in Solr and checked that all of our tests still pass.

On Nov 5, 2011, at 8:23 PM, Mahadev Konar wrote:

> Hi all,
> I have created a 3.4.0 rc 1. Thanks to all who helped and spent the
> Friday night fixing bugs :).
>
> *** Please download, test and VOTE before the
> *** vote closes 5pm PT on Saturday, Nov12***
>
> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-1/
>
> Should we release this?
>
> Please try out the release ASAP. Would appreciate early feedback.
>
> thanks
> mahadev

- Mark Miller
lucidimagination.com

Hi all,
 I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
ZOOKEEPER-1208 that were fixed last week.

*** Please download, test and VOTE before the
*** vote closes 5pm PT on Saturday, Nov22***

http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/

Should we release this?
thanks
mahadev

Sorry I meant,

** Tuesday, Nov 22 **.

thanks
mahadev

On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Hi all,
>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
> ZOOKEEPER-1208 that were fixed last week.
>
> *** Please download, test and VOTE before the
> *** vote closes 5pm PT on Saturday, Nov22***
>
> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>
> Should we release this?
>
>
> thanks
> mahadev
>

Minor update, had to change the bits since I had forgotten to fix
ZOOKEEPER-1299.

The bits are now uptodate. Please review and vote.

thanks
mahadev

On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Sorry I meant,
>
> ** Tuesday, Nov 22 **.
>
> thanks
> mahadev
>
> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Hi all,
>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>> ZOOKEEPER-1208 that were fixed last week.
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 5pm PT on Saturday, Nov22***
>>
>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>
>> Should we release this?
>>
>>
>> thanks
>> mahadev
>>
>

FYI,
 Pat pointed this out. There are some warnings with rat which are
incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
I plan to fix this for 3.4.1, leaving 3.4.0 as it is.

thanks
mahadev

On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Minor update, had to change the bits since I had forgotten to fix
> ZOOKEEPER-1299.
>
> The bits are now uptodate. Please review and vote.
>
> thanks
> mahadev
>
> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Sorry I meant,
>>
>> ** Tuesday, Nov 22 **.
>>
>> thanks
>> mahadev
>>
>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> Hi all,
>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>>> ZOOKEEPER-1208 that were fixed last week.
>>>
>>> *** Please download, test and VOTE before the
>>> *** vote closes 5pm PT on Saturday, Nov22***
>>>
>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>>
>>> Should we release this?
>>>
>>>
>>> thanks
>>> mahadev
>>>
>>
>

+1. Verified the sig and checksums. Checked RAT (ok with the exception
Mahadev listed). All the tests (incl c) are passing for me. Also ran
with quorum sizes of 3,4,7,9 testing server failure/restart and that
all worked. Also verified against 3.3.3 version of client (both java
and C) and that passed as well.

Looks good to me!

Patrick

On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> FYI,
>  Pat pointed this out. There are some warnings with rat which are
> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>
> thanks
> mahadev
>
> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Minor update, had to change the bits since I had forgotten to fix
>> ZOOKEEPER-1299.
>>
>> The bits are now uptodate. Please review and vote.
>>
>> thanks
>> mahadev
>>
>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> Sorry I meant,
>>>
>>> ** Tuesday, Nov 22 **.
>>>
>>> thanks
>>> mahadev
>>>
>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>>> Hi all,
>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>>>> ZOOKEEPER-1208 that were fixed last week.
>>>>
>>>> *** Please download, test and VOTE before the
>>>> *** vote closes 5pm PT on Saturday, Nov22***
>>>>
>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>>>
>>>> Should we release this?
>>>>
>>>>
>>>> thanks
>>>> mahadev
>>>>
>>>
>>
>

+1, ran unit tests plus some manual tests with three machines.

-Flavio

On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:

> +1. Verified the sig and checksums. Checked RAT (ok with the exception
> Mahadev listed). All the tests (incl c) are passing for me. Also ran
> with quorum sizes of 3,4,7,9 testing server failure/restart and that
> all worked. Also verified against 3.3.3 version of client (both java
> and C) and that passed as well.
>
> Looks good to me!
>
> Patrick
>
> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <[EMAIL PROTECTED]
> > wrote:
>> FYI,
>>  Pat pointed this out. There are some warnings with rat which are
>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>>
>> thanks
>> mahadev
>>
>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <[EMAIL PROTECTED]
>> > wrote:
>>> Minor update, had to change the bits since I had forgotten to fix
>>> ZOOKEEPER-1299.
>>>
>>> The bits are now uptodate. Please review and vote.
>>>
>>> thanks
>>> mahadev
>>>
>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[EMAIL PROTECTED]
>>> > wrote:
>>>> Sorry I meant,
>>>>
>>>> ** Tuesday, Nov 22 **.
>>>>
>>>> thanks
>>>> mahadev
>>>>
>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]
>>>> > wrote:
>>>>> Hi all,
>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>>>>> ZOOKEEPER-1208 that were fixed last week.
>>>>>
>>>>> *** Please download, test and VOTE before the
>>>>> *** vote closes 5pm PT on Saturday, Nov22***
>>>>>
>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>>>>
>>>>> Should we release this?
>>>>>
>>>>>
>>>>> thanks
>>>>> mahadev
>>>>>
>>>>
>>>
>>

flavio
junqueira

research scientist

[EMAIL PROTECTED]
direct +34 93-183-8828

avinguda diagonal 177, 8th floor, barcelona, 08018, es
phone (408) 349 3300    fax (408) 349 3301

+1. looks good. one issue i found, which is i'm not sure if it is an
issue or not due to my ignorance of maven, is that i had to specify
the packaging when installing the jar file into my local repository:

mvn install:install-file
-Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
-Dpackaging=jar
-DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom

if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
rather than pom i don't need the -Dpackaging flag. i'm not sure if
that is how it is supposed to be. (and even if it is a bug, it is not
a release blocker.)

ben

On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]> wrote:
> +1, ran unit tests plus some manual tests with three machines.
>
> -Flavio
>
> On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
>
>> +1. Verified the sig and checksums. Checked RAT (ok with the exception
>> Mahadev listed). All the tests (incl c) are passing for me. Also ran
>> with quorum sizes of 3,4,7,9 testing server failure/restart and that
>> all worked. Also verified against 3.3.3 version of client (both java
>> and C) and that passed as well.
>>
>> Looks good to me!
>>
>> Patrick
>>
>> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <[EMAIL PROTECTED]>
>> wrote:
>>>
>>> FYI,
>>>  Pat pointed this out. There are some warnings with rat which are
>>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
>>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>>>
>>> thanks
>>> mahadev
>>>
>>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <[EMAIL PROTECTED]>
>>> wrote:
>>>>
>>>> Minor update, had to change the bits since I had forgotten to fix
>>>> ZOOKEEPER-1299.
>>>>
>>>> The bits are now uptodate. Please review and vote.
>>>>
>>>> thanks
>>>> mahadev
>>>>
>>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <[EMAIL PROTECTED]>
>>>> wrote:
>>>>>
>>>>> Sorry I meant,
>>>>>
>>>>> ** Tuesday, Nov 22 **.
>>>>>
>>>>> thanks
>>>>> mahadev
>>>>>
>>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
>>>>> <[EMAIL PROTECTED]> wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>>>>>> ZOOKEEPER-1208 that were fixed last week.
>>>>>>
>>>>>> *** Please download, test and VOTE before the
>>>>>> *** vote closes 5pm PT on Saturday, Nov22***
>>>>>>
>>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>>>>>
>>>>>> Should we release this?
>>>>>>
>>>>>>
>>>>>> thanks
>>>>>> mahadev
>>>>>>
>>>>>
>>>>
>>>
>
> flavio
> junqueira
>
> research scientist
>
> [EMAIL PROTECTED]
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300    fax (408) 349 3301
>
>

mvn install should have done that for you.

On Fri, Nov 18, 2011 at 7:42 AM, Benjamin Reed <[EMAIL PROTECTED]> wrote:

> +1. looks good. one issue i found, which is i'm not sure if it is an
> issue or not due to my ignorance of maven, is that i had to specify
> the packaging when installing the jar file into my local repository:
>
> mvn install:install-file
> -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
> -Dpackaging=jar
> -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom
>
> if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
> rather than pom i don't need the -Dpackaging flag. i'm not sure if
> that is how it is supposed to be. (and even if it is a bug, it is not
> a release blocker.)
>
> ben
>
> On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]>
> wrote:
> > +1, ran unit tests plus some manual tests with three machines.
> >
> > -Flavio
> >
> > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
> >
> >> +1. Verified the sig and checksums. Checked RAT (ok with the exception
> >> Mahadev listed). All the tests (incl c) are passing for me. Also ran
> >> with quorum sizes of 3,4,7,9 testing server failure/restart and that
> >> all worked. Also verified against 3.3.3 version of client (both java
> >> and C) and that passed as well.
> >>
> >> Looks good to me!
> >>
> >> Patrick
> >>
> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >> wrote:
> >>>
> >>> FYI,
> >>>  Pat pointed this out. There are some warnings with rat which are
> >>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
> >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
> >>>
> >>> thanks
> >>> mahadev
> >>>
> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >>> wrote:
> >>>>
> >>>> Minor update, had to change the bits since I had forgotten to fix
> >>>> ZOOKEEPER-1299.
> >>>>
> >>>> The bits are now uptodate. Please review and vote.
> >>>>
> >>>> thanks
> >>>> mahadev
> >>>>
> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >>>> wrote:
> >>>>>
> >>>>> Sorry I meant,
> >>>>>
> >>>>> ** Tuesday, Nov 22 **.
> >>>>>
> >>>>> thanks
> >>>>> mahadev
> >>>>>
> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
> >>>>> <[EMAIL PROTECTED]> wrote:
> >>>>>>
> >>>>>> Hi all,
> >>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
> >>>>>> ZOOKEEPER-1208 that were fixed last week.
> >>>>>>
> >>>>>> *** Please download, test and VOTE before the
> >>>>>> *** vote closes 5pm PT on Saturday, Nov22***
> >>>>>>
> >>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
> >>>>>>
> >>>>>> Should we release this?
> >>>>>>
> >>>>>>
> >>>>>> thanks
> >>>>>> mahadev
> >>>>>>
> >>>>>
> >>>>
> >>>
> >
> > flavio
> > junqueira
> >
> > research scientist
> >
> > [EMAIL PROTECTED]
> > direct +34 93-183-8828
> >
> > avinguda diagonal 177, 8th floor, barcelona, 08018, es
> > phone (408) 349 3300    fax (408) 349 3301
> >
> >
>

As in "mvn install" without any fanciness.

A major point of mvn is that it has a standardized life-cycle.  Those are
all of the targets without colons.  For debugging and special cases, you
sometimes use one of the colon-ized targets, but that should be desperately
rare.

On Fri, Nov 18, 2011 at 10:01 AM, Ted Dunning <[EMAIL PROTECTED]> wrote:

> mvn install should have done that for you.
>
>
> On Fri, Nov 18, 2011 at 7:42 AM, Benjamin Reed <[EMAIL PROTECTED]> wrote:
>
>> +1. looks good. one issue i found, which is i'm not sure if it is an
>> issue or not due to my ignorance of maven, is that i had to specify
>> the packaging when installing the jar file into my local repository:
>>
>> mvn install:install-file
>> -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
>> -Dpackaging=jar
>> -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom
>>
>> if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
>> rather than pom i don't need the -Dpackaging flag. i'm not sure if
>> that is how it is supposed to be. (and even if it is a bug, it is not
>> a release blocker.)
>>
>> ben
>>
>> On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]>
>> wrote:
>> > +1, ran unit tests plus some manual tests with three machines.
>> >
>> > -Flavio
>> >
>> > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
>> >
>> >> +1. Verified the sig and checksums. Checked RAT (ok with the exception
>> >> Mahadev listed). All the tests (incl c) are passing for me. Also ran
>> >> with quorum sizes of 3,4,7,9 testing server failure/restart and that
>> >> all worked. Also verified against 3.3.3 version of client (both java
>> >> and C) and that passed as well.
>> >>
>> >> Looks good to me!
>> >>
>> >> Patrick
>> >>
>> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >> wrote:
>> >>>
>> >>> FYI,
>> >>>  Pat pointed this out. There are some warnings with rat which are
>> >>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
>> >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>> >>>
>> >>> thanks
>> >>> mahadev
>> >>>
>> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >>> wrote:
>> >>>>
>> >>>> Minor update, had to change the bits since I had forgotten to fix
>> >>>> ZOOKEEPER-1299.
>> >>>>
>> >>>> The bits are now uptodate. Please review and vote.
>> >>>>
>> >>>> thanks
>> >>>> mahadev
>> >>>>
>> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >>>> wrote:
>> >>>>>
>> >>>>> Sorry I meant,
>> >>>>>
>> >>>>> ** Tuesday, Nov 22 **.
>> >>>>>
>> >>>>> thanks
>> >>>>> mahadev
>> >>>>>
>> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
>> >>>>> <[EMAIL PROTECTED]> wrote:
>> >>>>>>
>> >>>>>> Hi all,
>> >>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>> >>>>>> ZOOKEEPER-1208 that were fixed last week.
>> >>>>>>
>> >>>>>> *** Please download, test and VOTE before the
>> >>>>>> *** vote closes 5pm PT on Saturday, Nov22***
>> >>>>>>
>> >>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>> >>>>>>
>> >>>>>> Should we release this?
>> >>>>>>
>> >>>>>>
>> >>>>>> thanks
>> >>>>>> mahadev
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>
>> >
>> > flavio
>> > junqueira
>> >
>> > research scientist
>> >
>> > [EMAIL PROTECTED]
>> > direct +34 93-183-8828
>> >
>> > avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> > phone (408) 349 3300    fax (408) 349 3301
>> >
>> >
>>
>
>

Would love to get some support on this jira, 3.5.0 based off maven
would address all of this, and make the RM process easier:
https://issues.apache.org/jira/browse/ZOOKEEPER-1078

Patrick

On Fri, Nov 18, 2011 at 10:02 AM, Ted Dunning <[EMAIL PROTECTED]> wrote:
> As in "mvn install" without any fanciness.
>
> A major point of mvn is that it has a standardized life-cycle.  Those are
> all of the targets without colons.  For debugging and special cases, you
> sometimes use one of the colon-ized targets, but that should be desperately
> rare.
>
> On Fri, Nov 18, 2011 at 10:01 AM, Ted Dunning <[EMAIL PROTECTED]> wrote:
>
>> mvn install should have done that for you.
>>
>>
>> On Fri, Nov 18, 2011 at 7:42 AM, Benjamin Reed <[EMAIL PROTECTED]> wrote:
>>
>>> +1. looks good. one issue i found, which is i'm not sure if it is an
>>> issue or not due to my ignorance of maven, is that i had to specify
>>> the packaging when installing the jar file into my local repository:
>>>
>>> mvn install:install-file
>>> -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
>>> -Dpackaging=jar
>>> -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom
>>>
>>> if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
>>> rather than pom i don't need the -Dpackaging flag. i'm not sure if
>>> that is how it is supposed to be. (and even if it is a bug, it is not
>>> a release blocker.)
>>>
>>> ben
>>>
>>> On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]>
>>> wrote:
>>> > +1, ran unit tests plus some manual tests with three machines.
>>> >
>>> > -Flavio
>>> >
>>> > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
>>> >
>>> >> +1. Verified the sig and checksums. Checked RAT (ok with the exception
>>> >> Mahadev listed). All the tests (incl c) are passing for me. Also ran
>>> >> with quorum sizes of 3,4,7,9 testing server failure/restart and that
>>> >> all worked. Also verified against 3.3.3 version of client (both java
>>> >> and C) and that passed as well.
>>> >>
>>> >> Looks good to me!
>>> >>
>>> >> Patrick
>>> >>
>>> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <
>>> [EMAIL PROTECTED]>
>>> >> wrote:
>>> >>>
>>> >>> FYI,
>>> >>>  Pat pointed this out. There are some warnings with rat which are
>>> >>> incorrect, jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1300
>>> >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>>> >>>
>>> >>> thanks
>>> >>> mahadev
>>> >>>
>>> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <
>>> [EMAIL PROTECTED]>
>>> >>> wrote:
>>> >>>>
>>> >>>> Minor update, had to change the bits since I had forgotten to fix
>>> >>>> ZOOKEEPER-1299.
>>> >>>>
>>> >>>> The bits are now uptodate. Please review and vote.
>>> >>>>
>>> >>>> thanks
>>> >>>> mahadev
>>> >>>>
>>> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <
>>> [EMAIL PROTECTED]>
>>> >>>> wrote:
>>> >>>>>
>>> >>>>> Sorry I meant,
>>> >>>>>
>>> >>>>> ** Tuesday, Nov 22 **.
>>> >>>>>
>>> >>>>> thanks
>>> >>>>> mahadev
>>> >>>>>
>>> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
>>> >>>>> <[EMAIL PROTECTED]> wrote:
>>> >>>>>>
>>> >>>>>> Hi all,
>>> >>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>>> >>>>>> ZOOKEEPER-1208 that were fixed last week.
>>> >>>>>>
>>> >>>>>> *** Please download, test and VOTE before the
>>> >>>>>> *** vote closes 5pm PT on Saturday, Nov22***
>>> >>>>>>
>>> >>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
>>> >>>>>>
>>> >>>>>> Should we release this?
>>> >>>>>>
>>> >>>>>>
>>> >>>>>> thanks
>>> >>>>>> mahadev
>>> >>>>>>
>>> >>>>>
>>> >>>>
>>> >>>
>>> >
>>> > flavio
>>> > junqueira
>>> >
>>> > research scientist
>>> >
>>> > [EMAIL PROTECTED]
>>> > direct +34 93-183-8828
>>> >
>>> > avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>> > phone (408) 349 3300    fax (408) 349 3301
>>> >
>>> >
>>>
>>
>>
>

No promises, but I think that this is wonderful work and will see what I
can liberate in terms of time.

On Fri, Nov 18, 2011 at 10:13 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> Would love to get some support on this jira, 3.5.0 based off maven
> would address all of this, and make the RM process easier:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1078
>
> Patrick
>
> On Fri, Nov 18, 2011 at 10:02 AM, Ted Dunning <[EMAIL PROTECTED]>
> wrote:
> > As in "mvn install" without any fanciness.
> >
> > A major point of mvn is that it has a standardized life-cycle.  Those are
> > all of the targets without colons.  For debugging and special cases, you
> > sometimes use one of the colon-ized targets, but that should be
> desperately
> > rare.
> >
> > On Fri, Nov 18, 2011 at 10:01 AM, Ted Dunning <[EMAIL PROTECTED]>
> wrote:
> >
> >> mvn install should have done that for you.
> >>
> >>
> >> On Fri, Nov 18, 2011 at 7:42 AM, Benjamin Reed <[EMAIL PROTECTED]>
> wrote:
> >>
> >>> +1. looks good. one issue i found, which is i'm not sure if it is an
> >>> issue or not due to my ignorance of maven, is that i had to specify
> >>> the packaging when installing the jar file into my local repository:
> >>>
> >>> mvn install:install-file
> >>> -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
> >>> -Dpackaging=jar
> >>> -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom
> >>>
> >>> if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
> >>> rather than pom i don't need the -Dpackaging flag. i'm not sure if
> >>> that is how it is supposed to be. (and even if it is a bug, it is not
> >>> a release blocker.)
> >>>
> >>> ben
> >>>
> >>> On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]>
> >>> wrote:
> >>> > +1, ran unit tests plus some manual tests with three machines.
> >>> >
> >>> > -Flavio
> >>> >
> >>> > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
> >>> >
> >>> >> +1. Verified the sig and checksums. Checked RAT (ok with the
> exception
> >>> >> Mahadev listed). All the tests (incl c) are passing for me. Also ran
> >>> >> with quorum sizes of 3,4,7,9 testing server failure/restart and that
> >>> >> all worked. Also verified against 3.3.3 version of client (both java
> >>> >> and C) and that passed as well.
> >>> >>
> >>> >> Looks good to me!
> >>> >>
> >>> >> Patrick
> >>> >>
> >>> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <
> >>> [EMAIL PROTECTED]>
> >>> >> wrote:
> >>> >>>
> >>> >>> FYI,
> >>> >>>  Pat pointed this out. There are some warnings with rat which are
> >>> >>> incorrect, jira:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1300
> >>> >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
> >>> >>>
> >>> >>> thanks
> >>> >>> mahadev
> >>> >>>
> >>> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <
> >>> [EMAIL PROTECTED]>
> >>> >>> wrote:
> >>> >>>>
> >>> >>>> Minor update, had to change the bits since I had forgotten to fix
> >>> >>>> ZOOKEEPER-1299.
> >>> >>>>
> >>> >>>> The bits are now uptodate. Please review and vote.
> >>> >>>>
> >>> >>>> thanks
> >>> >>>> mahadev
> >>> >>>>
> >>> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <
> >>> [EMAIL PROTECTED]>
> >>> >>>> wrote:
> >>> >>>>>
> >>> >>>>> Sorry I meant,
> >>> >>>>>
> >>> >>>>> ** Tuesday, Nov 22 **.
> >>> >>>>>
> >>> >>>>> thanks
> >>> >>>>> mahadev
> >>> >>>>>
> >>> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
> >>> >>>>> <[EMAIL PROTECTED]> wrote:
> >>> >>>>>>
> >>> >>>>>> Hi all,
> >>> >>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
> >>> >>>>>> ZOOKEEPER-1208 that were fixed last week.
> >>> >>>>>>
> >>> >>>>>> *** Please download, test and VOTE before the
> >>> >>>>>> *** vote closes 5pm PT on Saturday, Nov22***
> >>> >>>>>>
> >>> >>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-2/
> >>> >>>>>>
> >>> >>>>>> Should we release this?
> >>> >>>>>>
> >>> >>>>>>
> >>> >>>>>> thanks
> >>> >>>>>> mahadev

Thanks Ted! I'm planning to commit it to trunk soon, will make it
easier to try and and have ppl submit patches (ant/build.xml will
continue on until mvn is ready to replace it).

Patrick

On Fri, Nov 18, 2011 at 2:55 PM, Ted Dunning <[EMAIL PROTECTED]> wrote:
> No promises, but I think that this is wonderful work and will see what I
> can liberate in terms of time.
>
> On Fri, Nov 18, 2011 at 10:13 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> Would love to get some support on this jira, 3.5.0 based off maven
>> would address all of this, and make the RM process easier:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1078
>>
>> Patrick
>>
>> On Fri, Nov 18, 2011 at 10:02 AM, Ted Dunning <[EMAIL PROTECTED]>
>> wrote:
>> > As in "mvn install" without any fanciness.
>> >
>> > A major point of mvn is that it has a standardized life-cycle.  Those are
>> > all of the targets without colons.  For debugging and special cases, you
>> > sometimes use one of the colon-ized targets, but that should be
>> desperately
>> > rare.
>> >
>> > On Fri, Nov 18, 2011 at 10:01 AM, Ted Dunning <[EMAIL PROTECTED]>
>> wrote:
>> >
>> >> mvn install should have done that for you.
>> >>
>> >>
>> >> On Fri, Nov 18, 2011 at 7:42 AM, Benjamin Reed <[EMAIL PROTECTED]>
>> wrote:
>> >>
>> >>> +1. looks good. one issue i found, which is i'm not sure if it is an
>> >>> issue or not due to my ignorance of maven, is that i had to specify
>> >>> the packaging when installing the jar file into my local repository:
>> >>>
>> >>> mvn install:install-file
>> >>> -Dfile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.jar
>> >>> -Dpackaging=jar
>> >>> -DpomFile=/tmp/zookeeper-3.4.0/dist-maven/zookeeper-3.4.0-test.pom
>> >>>
>> >>> if i change zookeeper-3.4.0-test.pom to set the packaging type to jar
>> >>> rather than pom i don't need the -Dpackaging flag. i'm not sure if
>> >>> that is how it is supposed to be. (and even if it is a bug, it is not
>> >>> a release blocker.)
>> >>>
>> >>> ben
>> >>>
>> >>> On Wed, Nov 16, 2011 at 2:07 PM, Flavio Junqueira <[EMAIL PROTECTED]>
>> >>> wrote:
>> >>> > +1, ran unit tests plus some manual tests with three machines.
>> >>> >
>> >>> > -Flavio
>> >>> >
>> >>> > On Nov 16, 2011, at 10:49 PM, Patrick Hunt wrote:
>> >>> >
>> >>> >> +1. Verified the sig and checksums. Checked RAT (ok with the
>> exception
>> >>> >> Mahadev listed). All the tests (incl c) are passing for me. Also ran
>> >>> >> with quorum sizes of 3,4,7,9 testing server failure/restart and that
>> >>> >> all worked. Also verified against 3.3.3 version of client (both java
>> >>> >> and C) and that passed as well.
>> >>> >>
>> >>> >> Looks good to me!
>> >>> >>
>> >>> >> Patrick
>> >>> >>
>> >>> >> On Wed, Nov 16, 2011 at 11:45 AM, Mahadev Konar <
>> >>> [EMAIL PROTECTED]>
>> >>> >> wrote:
>> >>> >>>
>> >>> >>> FYI,
>> >>> >>>  Pat pointed this out. There are some warnings with rat which are
>> >>> >>> incorrect, jira:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1300
>> >>> >>> I plan to fix this for 3.4.1, leaving 3.4.0 as it is.
>> >>> >>>
>> >>> >>> thanks
>> >>> >>> mahadev
>> >>> >>>
>> >>> >>> On Tue, Nov 15, 2011 at 11:35 PM, Mahadev Konar <
>> >>> [EMAIL PROTECTED]>
>> >>> >>> wrote:
>> >>> >>>>
>> >>> >>>> Minor update, had to change the bits since I had forgotten to fix
>> >>> >>>> ZOOKEEPER-1299.
>> >>> >>>>
>> >>> >>>> The bits are now uptodate. Please review and vote.
>> >>> >>>>
>> >>> >>>> thanks
>> >>> >>>> mahadev
>> >>> >>>>
>> >>> >>>> On Tue, Nov 15, 2011 at 6:31 PM, Mahadev Konar <
>> >>> [EMAIL PROTECTED]>
>> >>> >>>> wrote:
>> >>> >>>>>
>> >>> >>>>> Sorry I meant,
>> >>> >>>>>
>> >>> >>>>> ** Tuesday, Nov 22 **.
>> >>> >>>>>
>> >>> >>>>> thanks
>> >>> >>>>> mahadev
>> >>> >>>>>
>> >>> >>>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar
>> >>> >>>>> <[EMAIL PROTECTED]> wrote:
>> >>> >>>>>>
>> >>> >>>>>> Hi all,
>> >>> >>>>>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>> >>> >>>>>> ZOOKEEPER-1208 that were fixed last week.

> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> *** Please download, test and VOTE before the
> *** vote closes 5pm PT on Saturday, Nov22***

+1. I pulled 3.4.0 into Bigtop and rebuilt the entire stack over here:
    http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/

Folks interested in testing *clients* of ZK can install everything in the usual
manner from packages ([X] stands for centos5, centos6, fedora15, sles11, lucid):
   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/label=[X]/lastSuccessfulBuild/artifact/output/bigtop.repo

I also executed HBase running with this RC:
   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-rc-smoketest/11/

Thanks,
Roman.

Thanks for taking it for a spin Roman.

I tried out the RC. Also did a backwards compatibility test with 3.3.*
and made sure the old clients can talk to new servers and also the
other way around.

+1 from me.

thanks
mahadev

On Sat, Nov 19, 2011 at 6:59 PM, Roman Shaposhnik <[EMAIL PROTECTED]> wrote:
>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> *** Please download, test and VOTE before the
>> *** vote closes 5pm PT on Saturday, Nov22***
>
> +1. I pulled 3.4.0 into Bigtop and rebuilt the entire stack over here:
>    http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/
>
> Folks interested in testing *clients* of ZK can install everything in the usual
> manner from packages ([X] stands for centos5, centos6, fedora15, sles11, lucid):
>   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/label=[X]/lastSuccessfulBuild/artifact/output/bigtop.repo
>
> I also executed HBase running with this RC:
>   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-rc-smoketest/11/
>
> Thanks,
> Roman.
>

With 4 +1's (binding) and one +1 non binding, the vote passes. Ill do
the needful on the release now.

Thanks for everyones hard work on this one.

thanks
mahadev

On Tue, Nov 22, 2011 at 11:07 AM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Thanks for taking it for a spin Roman.
>
> I tried out the RC. Also did a backwards compatibility test with 3.3.*
> and made sure the old clients can talk to new servers and also the
> other way around.
>
> +1 from me.
>
> thanks
> mahadev
>
> On Sat, Nov 19, 2011 at 6:59 PM, Roman Shaposhnik <[EMAIL PROTECTED]> wrote:
>>> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> *** Please download, test and VOTE before the
>>> *** vote closes 5pm PT on Saturday, Nov22***
>>
>> +1. I pulled 3.4.0 into Bigtop and rebuilt the entire stack over here:
>>    http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/
>>
>> Folks interested in testing *clients* of ZK can install everything in the usual
>> manner from packages ([X] stands for centos5, centos6, fedora15, sles11, lucid):
>>   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-trunk-rc-zookeeper-3.4.0/label=[X]/lastSuccessfulBuild/artifact/output/bigtop.repo
>>
>> I also executed HBase running with this RC:
>>   http://bigtop01.cloudera.org:8080/view/RCs/job/Bigtop-rc-smoketest/11/
>>
>> Thanks,
>> Roman.
>>
>

On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Hi all,
>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
> ZOOKEEPER-1208 that were fixed last week.
>
> *** Please download, test and VOTE before the
> *** vote closes 5pm PT on Saturday, Nov22***
>

Late to the game but +1.  We have the 3.4.0 RC in tip of hbase 0.92
branch and it seems to be basically working (I've been doing small
cluster tests over last few days)

St.Ack

Thats great!

Thanks for the feedback Stack.

mahadev

On Tue, Nov 22, 2011 at 8:52 PM, Stack <[EMAIL PROTECTED]> wrote:
> On Tue, Nov 15, 2011 at 6:28 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Hi all,
>>  I have created a 3.4.0 rc 2. This has ZOOKEEPER-1239 and
>> ZOOKEEPER-1208 that were fixed last week.
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 5pm PT on Saturday, Nov22***
>>
>
> Late to the game but +1.  We have the 3.4.0 RC in tip of hbase 0.92
> branch and it seems to be basically working (I've been doing small
> cluster tests over last few days)
>
> St.Ack
>

Hi all,
 I have created a 3.4.0 release candidate. 3.4 is the first major
release after ZooKeeper became a TLP.
 The last major release 3.3.0 was done in March, 2010.
 3.4.0 includes a lot of features, improvements and bug fixes. Please
look at Release Notes for more information.

*** Please download, test and VOTE before the
*** vote closes 1am PDT on Tuesday, Nov1***

http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-0/

Should we release this?

Please make sure, you download and test the release ASAP. Early
feedback would be very helpful.

thanks
mahadev

-1

The distributed binaries work for starting a server client etc.

I get compile warnings:

compile:
    [javac] Compiling 145 source files to /Users/ivank/Junk/zookeeper-3.4.0/build/classes
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/Shell.java:276: warning: [serial] serializable class org.apache.zookeeper.Shell.ExitCodeException has no definition of serialVersionUID
    [javac]   public static class ExitCodeException extends IOException {
    [javac]                 ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:573: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new LeaderElection(this);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:576: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new AuthFastLeaderElection(this);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:579: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new AuthFastLeaderElection(this, true);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:600: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             electionAlg = new LeaderElection(this);
    [javac]                               ^
    [javac] 5 warnings

The first one can be fixed with "static final long serialVersionUID = 2977863941654513113L;". The deprecation may be a bit more involved though. You could suppress the warning, but really you should just remove the use of a deprecated class.

Also, while looking into that, I saw QuorumPeer.java has tabs in it.

org.apache.zookeeper.test.ClientPortBindTest fails, consistently.

This is on Mac OS 10.6.8
$ java -version
java version "1.6.0_26"
Java(TM) SE Runtime Environment (build 1.6.0_26-b03-384-10M3425)
Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02-384, mixed mode)

$ uname -a
Darwin spokegrown-lm 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386

-Ivan
On 25 Oct 2011, at 10:12, Mahadev Konar wrote:

> Hi all,
> I have created a 3.4.0 release candidate. 3.4 is the first major
> release after ZooKeeper became a TLP.
> The last major release 3.3.0 was done in March, 2010.
> 3.4.0 includes a lot of features, improvements and bug fixes. Please
> look at Release Notes for more information.
>
> *** Please download, test and VOTE before the
> *** vote closes 1am PDT on Tuesday, Nov1***
>
> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-0/
>
> Should we release this?
>
> Please make sure, you download and test the release ASAP. Early
> feedback would be very helpful.
>
> thanks
> mahadev

Thanks for trying out the release Ivan!

the compile warnings are a known issue (not something that should
block the release IMO), see this jira I filed:
https://issues.apache.org/jira/browse/ZOOKEEPER-1236

I believe Thomas has removed a lot of tabs from trunk... (not a blocker).

The test failure on macos is unfortunate, but give it's not a
"production" platform I don't think it should be considered a blocker
(although I may not be in the majority here...)
http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq

However I do notice that solaris is failing consistently (granted
trunk but likely the same issue in 3.4)
https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_trunk_solaris/

I'll let the release manager decide on whether solaris is a blocker or
if he just wants to release note it (and fix in 3.4.1) - Mahadev?

Patrick

On Tue, Oct 25, 2011 at 3:12 AM, Ivan Kelly <[EMAIL PROTECTED]> wrote:
> -1
>
> The distributed binaries work for starting a server client etc.
>
> I get compile warnings:
>
> compile:
>    [javac] Compiling 145 source files to /Users/ivank/Junk/zookeeper-3.4.0/build/classes
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/Shell.java:276: warning: [serial] serializable class org.apache.zookeeper.Shell.ExitCodeException has no definition of serialVersionUID
>    [javac]   public static class ExitCodeException extends IOException {
>    [javac]                 ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:573: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new LeaderElection(this);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:576: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new AuthFastLeaderElection(this);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:579: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new AuthFastLeaderElection(this, true);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:600: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             electionAlg = new LeaderElection(this);
>    [javac]                               ^
>    [javac] 5 warnings
>
> The first one can be fixed with "static final long serialVersionUID = 2977863941654513113L;". The deprecation may be a bit more involved though. You could suppress the warning, but really you should just remove the use of a deprecated class.
>
> Also, while looking into that, I saw QuorumPeer.java has tabs in it.
>
> org.apache.zookeeper.test.ClientPortBindTest fails, consistently.
>
> This is on Mac OS 10.6.8
> $ java -version
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03-384-10M3425)
> Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02-384, mixed mode)
>
> $ uname -a
> Darwin spokegrown-lm 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386
>
> -Ivan
>
>
> On 25 Oct 2011, at 10:12, Mahadev Konar wrote:
>
>> Hi all,
>> I have created a 3.4.0 release candidate. 3.4 is the first major
>> release after ZooKeeper became a TLP.
>> The last major release 3.3.0 was done in March, 2010.
>> 3.4.0 includes a lot of features, improvements and bug fixes. Please
>> look at Release Notes for more information.

> the compile warnings are a known issue (not something that should
> block the release IMO), see this jira I filed:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1236
That only refers to the proprietary sun apis. Is there a JIRA that covers the use of Zookeeper's own deprecated classes also?
>
> The test failure on macos is unfortunate, but give it's not a
> "production" platform I don't think it should be considered a blocker
> (although I may not be in the majority here...)
> http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq
Sure, I've just tested on a linux box and it doesn't seem to happen.

I've also just notices that this actual tarball isn't actually gzipped.

$ file zookeeper-3.4.0.tar.gz
zookeeper-3.4.0.tar.gz: POSIX tar archive

-Ivan

Thanks for pointing out Ivan. That might be a mistake on my side :).
Will fix that.

Again, folks, please try out the release ASAP. We do have a couple of
issues to fix but lets find all the issues we can and then see what we
want to fix in 3.4.0.

thanks
mahadev

On Tue, Oct 25, 2011 at 9:25 AM, Ivan Kelly <[EMAIL PROTECTED]> wrote:
>> the compile warnings are a known issue (not something that should
>> block the release IMO), see this jira I filed:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1236
> That only refers to the proprietary sun apis. Is there a JIRA that covers the use of Zookeeper's own deprecated classes also?
>>
>> The test failure on macos is unfortunate, but give it's not a
>> "production" platform I don't think it should be considered a blocker
>> (although I may not be in the majority here...)
>> http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq
> Sure, I've just tested on a linux box and it doesn't seem to happen.
>
> I've also just notices that this actual tarball isn't actually gzipped.
>
> $ file zookeeper-3.4.0.tar.gz
> zookeeper-3.4.0.tar.gz: POSIX tar archive
>
> -Ivan
>
>