Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request: DRILL-55 - RSERegistry does not store built engines into availableEngines map


Copy link to this message
-
Re: Review Request: DRILL-55 - RSERegistry does not store built engines into availableEngines map
David Alves 2013-03-27, 05:10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10146/
-----------------------------------------------------------

(Updated March 27, 2013, 5:10 a.m.)
Review request for drill.
Description
-------

RSERegistry never stores the engines built in getEngine() into the availableEngines map, which causes a new engine instance to be built in every call and prevents direct interaction with an engine.

Specific problem: trying to override a specific configuration for testing doesn't work because getEngine always returns a new instance.
Diffs (updated)
-----

  sandbox/prototype/exec/ref/src/main/java/org/apache/drill/exec/ref/rse/RSERegistry.java 4266aac
  sandbox/prototype/exec/ref/src/test/java/org/apache/drill/exec/ref/RSERegistryTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/10146/diff/
Testing
-------
Thanks,

David Alves