Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: Replace object descriptor with detailed component type plus name


Copy link to this message
-
Re: Review Request: Replace object descriptor with detailed component type plus name
Ted Malaska 2012-09-10, 18:28

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6944/
-----------------------------------------------------------

(Updated Sept. 10, 2012, 6:28 p.m.)
Review request for Flume.
Changes
-------

Removed spaces from patch
Description
-------

In the existing code when calling toString of a channel, sink, or source will output something like the following

org.apache.flume.channel.MemoryChannel@594ab51b

I over rided the toString method is the abstract classes of channel, sink, and source to output something more meaningful like the following

org.somthing.Channel {name:bob}
org.somthing.Sink {name:bob, channel:bob}
org.somthing.Source {name:bob, state:IDLE}
This addresses bug FLUME-1480.
    https://issues.apache.org/jira/browse/FLUME-1480
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08
  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java 7ecc1c9
  flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java 5eeb687

Diff: https://reviews.apache.org/r/6944/diff/
Testing
-------
Thanks,

Ted Malaska