Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands


Copy link to this message
-
Re: Review Request 13181: SQOOP-773 Sqoop2: Batch execution support for client commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13181/#review25849
-----------------------------------------------------------
Hi Abe,
thank you very much for working on this. Would you mind rebasing the patch on current HEAD of sqoop2 branch? We've recently split the client module into separate shell and client module via SQOOP-921, so the patch no longer applies cleanly. Couple of high level notes:
server/src/main/java/org/apache/sqoop/server/v1/FrameworkServlet.java
<https://reviews.apache.org/r/13181/#comment50408>

    Nit: This change do not seem to be necessary.

shell/src/main/java/org/apache/sqoop/shell/utils/ConnectionDynamicFormOptions.java
<https://reviews.apache.org/r/13181/#comment50409>

    This file is missing license header.

shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java
<https://reviews.apache.org/r/13181/#comment50410>

    This file is missing license header.

shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java
<https://reviews.apache.org/r/13181/#comment50412>

    We're adding here .hasArg()  in all cases (for all input types), however the usage of boolean inputs in fillInputBoolean() method suggest that we are not expecting any arguments as we are just verifying if the parameter was used or not.

shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java
<https://reviews.apache.org/r/13181/#comment50411>

    This file is missing license header.
Jarcec

- Jarek Cecho
On Aug. 13, 2013, 9:30 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13181/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 9:30 p.m.)
>
>
> Review request for Sqoop, Hari Shreedharan and Jarek Cecho.
>
>
> Bugs: SQOOP-773
>     https://issues.apache.org/jira/browse/SQOOP-773
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d894ac7b09a18f3fed1fb58bed7554a873fa8630
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Wed Jul 31 14:23:58 2013 -0700
>
>     SQOOP-773 Sqoop2: Batch execution support for client commands
>    
>     Separated options into two groups: fixed and dynamic options.
>     Fixed options (IE: connector ID) come first and are used to select
>     what options should be used in dynamic options. Dynamic options
>     are automatically created based on forms selected from fixed options.
>     The keys for these options take on the form "<prefix>-<form name>-<input-name>".
>
> :100644 100644 0538901... 7f5df34... M client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
> :100644 100644 6f62813... 32f8c3f... M client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
> :100644 100644 ac555e1... c842c4d... M client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java
> :100644 100644 04b240c... f23e479... M client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
> :100644 100644 cc4d546... 7b40645... M client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
> :100644 100644 18d3a70... 5220d61... M client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
> :100644 100644 736be20... e82a47b... M client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
> :100644 100644 e04292a... f6cd6e3... M client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
> :100644 100644 5962cd2... 6ea9f0c... M client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
> :100644 100644 ed6dc3c... 094438b... M client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
> :100644 100644 9e4e320... fb75fa8... M client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java