Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-918 Sqoop2: Introduce client API and change Sqoop shell to use it


Copy link to this message
-
Re: Review Request: SQOOP-918 Sqoop2: Introduce client API and change Sqoop shell to use it

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9717/#review17674
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On March 11, 2013, 2:21 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9717/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 2:21 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've created first simple SqoopClient API and altered shell to use it. I've noticed that there is a lot of duplicate code in the shell, so I've tried to clean it up. The changes are simple, however are spanning across all shell files, thus making this patch bigger than necessary.
>
> This is first implementation of the SqoopClient API. I'm intending to improve it, for example by caching objects that was already received (especially connector info and resource bundles). As this patch is big enough already, I would prefer to finish this functionality in follow up JIRA.
>
>
> This addresses bug SQOOP-918.
>     https://issues.apache.org/jira/browse/SQOOP-918
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java c364aa8856bf02f501b0ca2f3630c8e8c6fd10b1
>   client/src/main/java/org/apache/sqoop/client/core/Environment.java 5d1af26a0e8f96c11c7ef7d8fcfd0013db5ccce6
>   client/src/main/java/org/apache/sqoop/client/core/RequestCache.java 808b9f15d52ba9d3620e094a3640b6a93e2b0848
>   client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java f1e4d685eb0466e916ede21e23f6766f6b263c27
>   client/src/main/java/org/apache/sqoop/client/request/ConnectorRequest.java 9ea9d5db91cb28337ef4b6d997af9d0cd0ef7781
>   client/src/main/java/org/apache/sqoop/client/request/JobRequest.java c2449f5106e2918b5e5068ff41733def68180804
>   client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 60dcbb29cb75106c58d4de29a6160c1976bc4d67
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java abec66b4bdcd10bfe6a7b62e421a131083359b5e
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 9d6c39627fc7c244adfc6a23a0d6470ab834ee9e
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java d06f05113cee801e0d956aa2f07f12f6bf748c46
>   client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java f4872d2822859739d0bf86c32d349190905d52ad
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 2c750d337a34a6e2c08f524dfa61a3c287f385d1
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1f01cc75b5be572385c8ad3c6c20e33903e88fd6
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java 38b2fdade23a046e6f4e5c5fcfb823d88181db02
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java 154acc7382335773f65569c045d7a4dff02eb728
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 9d6c53e7fcf4e43753c20668697bdfb25168b927
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java e14f738d5fd77ed7f7ec913cae2456aa4edd2123
>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java 6c17e2515c6c034feb6569b6f8b40e53504b6412
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 5d5e9e7570e432c2e8c00c656153a2f1c09bb14c
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 0e1e027c04829cb9e00fc307d182dccc9c119fcf
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java PRE-CREATION
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java a043aa339b8617e17216627c425362f305e9ac1b