Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: Review Request 12048: SQOOP-999: Support bulk load from HDFS to PostgreSQL using COPY ... FROM


Copy link to this message
-
Re: Review Request 12048: SQOOP-999: Support bulk load from HDFS to PostgreSQL using COPY ... FROM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12048/#review22678
-----------------------------------------------------------
Hi Masatake,
thank you very much for incorporating all my feedback. I do have one last nit and we are ready to get it in!
src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportMapper.java
<https://reviews.apache.org/r/12048/#comment46362>

    Nit: I'm slowly trying to clean up the giant package org.apache.sqoop.mapreduce. Would you mind putting this PostgreSQL specific implementation file into package org.apache.sqoop.mapreduce.postgresql? There are already packages for MySQL, Netezza or Microsoft SQL Server.
Jarcec

- Jarek Cecho
On July 2, 2013, 9:05 a.m., Masatake Iwasaki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12048/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 9:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-999
>     https://issues.apache.org/jira/browse/SQOOP-999
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Export with PostgreSQL Copy API can be realized in a straitforward way. Attached file is not complete patch but sample implementation without tests and consideration for corner cases.
> Though this code resolves dependency for PostgreSQL JDBC by ivy, is it acceptable for the project?
>
>
> Diffs
> -----
>
>   ivy.xml 750adfc
>   ivy/libraries.properties 430d554
>   src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java c085218
>   src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportJob.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportMapper.java PRE-CREATION
>   src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12048/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Masatake Iwasaki
>
>