Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 15630: SQOOP-1144 Sqoop2: Add fixVersion to PreCommit branch detection


Copy link to this message
-
Re: Review Request 15630: SQOOP-1144 Sqoop2: Add fixVersion to PreCommit branch detection


> On Nov. 18, 2013, 5:52 p.m., Abraham Elmahrek wrote:
> > dev-support/test-patch.py, lines 151-157
> > <https://reviews.apache.org/r/15630/diff/1/?file=386645#file386645line151>
> >
> >     The fixVersions part seems right, but are we just affectedVersions is working?
> >    
> >     https://developer.atlassian.com/display/JIRADEV/JIRA+JSON-RPC+Overview
> >     Checkout getIssue().
> >    
> >     It seems "versions" is the wrong key?
> >    
> >     Also, It seems those 2 fields aren't required to be provided: https://docs.atlassian.com/jira/REST/latest/#d2e1227.
> >    
> >     We should probably give a default to the "get" method of an empty list:
> >     for version in json.get("fields").get("fixVersions", []):

Hi Abe,
thank you for the review! Adding the default value is great idea, I'll upload new patch shortly.

I've also took a look in to "versions" versus "affectedVersions" field and found out that ASF JIRA is returning only "fixVersions" and "versions". There is no "affectedVersions" field at all. I'm assuming that there might be a change in some more recent JIRA versions.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15630/#review29049
-----------------------------------------------------------
On Nov. 17, 2013, 1:38 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15630/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2013, 1:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1144
>     https://issues.apache.org/jira/browse/SQOOP-1144
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added field fixVersion to branch detection.
>
>
> Diffs
> -----
>
>   dev-support/test-patch.py 0196cfa381751391ead13830503b29de15eda0dc
>
> Diff: https://reviews.apache.org/r/15630/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Jarek Cecho
>
>