|
|
-
Review Request: SQOOP-584: Create facility to validate user supplied connection and job formsJarek Cecho 2012-08-23, 08:36
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6748/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Description ------- This patch includes two set of changes: 1) I've moved validation support out of MNamedElement to MValidatedElement. My reasoning here is that those are two different actions and I do not need validation everywhere where I need a name. 2) I've added new Validation class and request connectors to supply validator object that will be used to perform validations. This addresses bug SQOOP-584. https://issues.apache.org/jira/browse/SQOOP-584 Diffs ----- /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MForm.java 1376378 /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MInput.java 1376378 /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MNamedElement.java 1376378 /branches/sqoop2/common/src/main/java/org/apache/sqoop/model/MValidatedElement.java PRE-CREATION /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 1376378 /branches/sqoop2/connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java 1376378 /branches/sqoop2/spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 1376378 /branches/sqoop2/spi/src/main/java/org/apache/sqoop/validation/Status.java PRE-CREATION /branches/sqoop2/spi/src/main/java/org/apache/sqoop/validation/Validator.java PRE-CREATION Diff: https://reviews.apache.org/r/6748/diff/ Testing ------- Thanks, Jarek Cecho |