Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hadoop >> mail # dev >> trailing whitespace


Copy link to this message
-
Re: trailing whitespace
Some projects have a subversion pre or post-commit hook to check for
and/or correct these kinds of issues.

Inconsistent line endings (CRLF/LF), bogus tabs, and extra whitespace
are all things we could check for and/or correct this way.

Colin
On Mon, Nov 26, 2012 at 9:44 AM, Aaron T. Myers <[EMAIL PROTECTED]> wrote:
> On Sun, Nov 25, 2012 at 11:14 AM, Radim Kolar <[EMAIL PROTECTED]> wrote:
>
>> I propose addition to QA bot - check for trailing whitespace in patches.
>> Probably checking for tabs in Java files would be also good idea.
>>
>>
> Checking for tabs I could get behind; checking for trailing whitespace not
> so much.
>
> I've never understood why folks get worked up over a little trailing
> whitespace here and there, since you can't see it and it doesn't affect
> correctness. Spurious whitespace changes that make a review harder - those
> are annoying. Trailing whitespace inadvertently left on lines where
> legitimate changes were made in a patch - doesn't seem too harmful to me.
>
> --
> Aaron T. Myers
> Software Engineer, Cloudera
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB