Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper >> mail # dev >> Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107


+
Edward Ribeiro 2013-01-23, 07:30
+
Alexander Shraer 2013-01-25, 07:43
+
Edward Ribeiro 2013-01-23, 07:20
+
Alexander Shraer 2013-01-25, 07:43
+
Edward Ribeiro 2013-01-23, 07:35
+
Edward Ribeiro 2013-01-23, 07:32
+
Edward Ribeiro 2013-01-23, 07:08
+
Alexander Shraer 2013-01-25, 07:43
+
Edward Ribeiro 2013-01-23, 06:57
+
Alexander Shraer 2013-01-25, 07:59
Copy link to this message
-
Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/#review15907
-----------------------------------------------------------
Hey Alex, I have a few minor points that would be cool if you could fix for the next version of the patch. They are really minor. One extra comment is that there is a lot of red in your patch (trailing and leading spaces, perhaps tabs too). The trunk code already has some, so it would be great not to introduce more. Please try to remove as much as possible. Otherwise, great job!
/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java
<https://reviews.apache.org/r/6707/#comment34182>

    you may want to break this line up, it seems too long.

/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java
<https://reviews.apache.org/r/6707/#comment34183>

    another long one.

/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
<https://reviews.apache.org/r/6707/#comment34184>

    I guess that the problem of having the quorum verifier info into stat is that we would have to ship it with every response? I was really looking for a way of removing the reference to QuorumZooKeeperServer.

/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
<https://reviews.apache.org/r/6707/#comment34186>

    Is the comment supposed to be an example? Can we have it on top of the statement and a more precise statement of what it is about?

/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
<https://reviews.apache.org/r/6707/#comment34187>

    Same here.

/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/6707/#comment34194>

    Could you explain me why you're shutting down leader election here? How can we get into this scenario?

/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/6707/#comment34192>

    If we are supposer to stop the peer, then this should be a fatal log message, don't simply dump the stack trace, use the log facility.

/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/6707/#comment34189>

    Can we fix the format of this comment?

/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/6707/#comment34190>

    Thanks for fixing this!

/src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
<https://reviews.apache.org/r/6707/#comment34180>

    The formatting for this method looks broken.
- fpj
On Jan. 25, 2013, 7:59 a.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6707/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 7:59 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-107
>
>
> Diffs
> -----
>
>   /src/c/include/proto.h 1438352
>   /src/c/include/zookeeper.h 1438352
>   /src/c/src/cli.c 1438352
>   /src/c/src/zookeeper.c 1438352
>   /src/java/main/org/apache/zookeeper/KeeperException.java 1438352
>   /src/java/main/org/apache/zookeeper/ZooDefs.java 1438352
>   /src/java/main/org/apache/zookeeper/ZooKeeper.java 1438352
>   /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1438352
>   /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/common/StringUtils.java 1438352
>   /src/java/main/org/apache/zookeeper/server/DataTree.java 1438352
>   /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1438352
>   /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1438348
+
Alexander Shraer 2013-01-31, 17:05
+
Alexander Shraer 2013-02-05, 05:07
+
Alexander Shraer 2013-02-06, 01:00
+
Edward Ribeiro 2013-03-22, 23:32