Joe,

0.8 now has compilation error after this check in. It seems that you forgot
to check in a new file. See my comment in kafka-240. Could you fix this?

Thanks,

Jun

On Fri, Mar 2, 2012 at 9:46 PM, <[EMAIL PROTECTED]> wrote:

> Author: joestein
> Date: Sat Mar  3 05:46:43 2012
> New Revision: 1296577
>
> URL: http://svn.apache.org/viewvc?rev=1296577&view=rev
> Log:
> KAFKA-240 ProducerRequest wire format protocol update and related changes
>
> Removed:
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/MultiProducerRequest.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/MultiMessageSetSend.scala
> Modified:
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/ProducerRequest.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/FetchResponse.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/ProducerRequest.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/producer/SyncProducer.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/ByteBufferMessageSet.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/FileMessageSet.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/MessageSet.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducer.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducerConfig.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala
>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/KafkaApis.scala
>    incubator/kafka/branches/0.8/core/src/main/scala/kafka/utils/Utils.scala
>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala
>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/utils/TestUtils.scala
>
> Modified:
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> URL:
> http://svn.apache.org/viewvc/incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala?rev=1296577&r1=1296576&r2=1296577&view=diff
>
> =============================================================================> ---
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> (original)
> +++
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> Sat Mar  3 05:46:43 2012
> @@ -39,6 +39,15 @@ object PartitionData {
>
>  case class PartitionData(partition: Int, error: Int > ErrorMapping.NoError, initialOffset:Long = 0L, messages: MessageSet) {
>   val sizeInBytes = 4 + 4 + 8 + 4 + messages.sizeInBytes.intValue()
> +
> +  def this(partition: Int, messages: MessageSet) = this(partition,
> ErrorMapping.NoError, 0L, messages)
> +
> +  def getTranslatedPartition(topic: String, randomSelector: String =>
> Int): Int = {
> +    if (partition == ProducerRequest.RandomPartition)
> +      return randomSelector(topic)
> +    else
> +      return partition
> +  }
>  }
>
>  object TopicData {
> @@ -73,6 +82,15 @@ object TopicData {
>
>  case class TopicData(topic: String, partitionData: Array[PartitionData]) {
>   val sizeInBytes = 2 + topic.length + partitionData.foldLeft(4)(_ +
> _.sizeInBytes)
> +
> +  override def equals(other: Any): Boolean = {
> +    other match {
> +      case that: TopicData =>
> +        ( topic == that.topic &&
> +          partitionData.toSeq == that.partitionData.toSeq )
> +      case _ => false
> +    }
> +  }
>  }
>
>  object FetchResponse {
>
> Modified:
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/ProducerRequest.scala

Also, I would recommend rebasing the 0.8 branch to the latest trunk
now. It has been quite a while since the last time I did a rebase.

Joe, would you mind helping with that ?

Thanks,
Neha

On Tue, Mar 6, 2012 at 9:15 AM, Jun Rao <[EMAIL PROTECTED]> wrote:
> Joe,
>
> 0.8 now has compilation error after this check in. It seems that you forgot
> to check in a new file. See my comment in kafka-240. Could you fix this?
>
> Thanks,
>
> Jun
>
> On Fri, Mar 2, 2012 at 9:46 PM, <[EMAIL PROTECTED]> wrote:
>
>> Author: joestein
>> Date: Sat Mar  3 05:46:43 2012
>> New Revision: 1296577
>>
>> URL: http://svn.apache.org/viewvc?rev=1296577&view=rev
>> Log:
>> KAFKA-240 ProducerRequest wire format protocol update and related changes
>>
>> Removed:
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/MultiProducerRequest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/MultiMessageSetSend.scala
>> Modified:
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/ProducerRequest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/FetchResponse.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/ProducerRequest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/producer/SyncProducer.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/ByteBufferMessageSet.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/FileMessageSet.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/MessageSet.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducer.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducerConfig.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala
>>
>>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/KafkaApis.scala
>>    incubator/kafka/branches/0.8/core/src/main/scala/kafka/utils/Utils.scala
>>
>>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
>>
>>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/utils/TestUtils.scala
>>
>> Modified:
>> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
>> URL:
>> http://svn.apache.org/viewvc/incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala?rev=1296577&r1=1296576&r2=1296577&view=diff
>>
>> =============================================================================>> ---
>> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
>> (original)
>> +++
>> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
>> Sat Mar  3 05:46:43 2012
>> @@ -39,6 +39,15 @@ object PartitionData {
>>
>>  case class PartitionData(partition: Int, error: Int >> ErrorMapping.NoError, initialOffset:Long = 0L, messages: MessageSet) {
>>   val sizeInBytes = 4 + 4 + 8 + 4 + messages.sizeInBytes.intValue()
>> +
>> +  def this(partition: Int, messages: MessageSet) = this(partition,
>> ErrorMapping.NoError, 0L, messages)
>> +
>> +  def getTranslatedPartition(topic: String, randomSelector: String =>
>> Int): Int = {
>> +    if (partition == ProducerRequest.RandomPartition)
>> +      return randomSelector(topic)
>> +    else
>> +      return partition
>> +  }
>>  }
>>
>>  object TopicData {
>> @@ -73,6 +82,15 @@ object TopicData {
>>
>>  case class TopicData(topic: String, partitionData: Array[PartitionData]) {
>>   val sizeInBytes = 2 + topic.length + partitionData.foldLeft(4)(_ +

let me take care of the missing file right now, sorry about that

if now is a good time to rebase the 0.8 branch to the latest trunk then yes
I can help with that probably won't have time until Thursday at the soonest
I think

On Tue, Mar 6, 2012 at 12:33 PM, Neha Narkhede <[EMAIL PROTECTED]>wrote:

> Also, I would recommend rebasing the 0.8 branch to the latest trunk
> now. It has been quite a while since the last time I did a rebase.
>
> Joe, would you mind helping with that ?
>
> Thanks,
> Neha
>
> On Tue, Mar 6, 2012 at 9:15 AM, Jun Rao <[EMAIL PROTECTED]> wrote:
> > Joe,
> >
> > 0.8 now has compilation error after this check in. It seems that you
> forgot
> > to check in a new file. See my comment in kafka-240. Could you fix this?
> >
> > Thanks,
> >
> > Jun
> >
> > On Fri, Mar 2, 2012 at 9:46 PM, <[EMAIL PROTECTED]> wrote:
> >
> >> Author: joestein
> >> Date: Sat Mar  3 05:46:43 2012
> >> New Revision: 1296577
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1296577&view=rev
> >> Log:
> >> KAFKA-240 ProducerRequest wire format protocol update and related
> changes
> >>
> >> Removed:
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/MultiProducerRequest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/MultiMessageSetSend.scala
> >> Modified:
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/ProducerRequest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/FetchResponse.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/ProducerRequest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/javaapi/producer/SyncProducer.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/ByteBufferMessageSet.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/FileMessageSet.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/message/MessageSet.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducer.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/SyncProducerConfig.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/server/KafkaApis.scala
> >>
>  incubator/kafka/branches/0.8/core/src/main/scala/kafka/utils/Utils.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
> >>
> >>
>  incubator/kafka/branches/0.8/core/src/test/scala/unit/kafka/utils/TestUtils.scala
> >>
> >> Modified:
> >>
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> >> URL:
> >>
> http://svn.apache.org/viewvc/incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala?rev=1296577&r1=1296576&r2=1296577&view=diff
> >>
> >>
> =============================================================================> >> ---
> >>
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> >> (original)
> >> +++
> >>
> incubator/kafka/branches/0.8/core/src/main/scala/kafka/api/FetchResponse.scala
> >> Sat Mar  3 05:46:43 2012
> >> @@ -39,6 +39,15 @@ object PartitionData {
> >>
> >>  case class PartitionData(partition: Int, error: Int > >> ErrorMapping.NoError, initialOffset:Long = 0L, messages: MessageSet) {
> >>   val sizeInBytes = 4 + 4 + 8 + 4 + messages.sizeInBytes.intValue()
> >> +
> >> +  def this(partition: Int, messages: MessageSet) = this(partition,
/*
Joe Stein
http://www.linkedin.com/in/charmalloc
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
*/