Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms


Copy link to this message
-
Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms
John Vines 2013-10-30, 17:07


> On Oct. 29, 2013, 3:25 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java, line 102
> > <https://reviews.apache.org/r/14972/diff/1/?file=371853#file371853line102>
> >
> >     I think I advocated somewhere for removing this method, because its not scaleable for every feature to have a seat at the table in the constructor.  The constructor that takes the config object nicely covers this use case.
>
> John Vines wrote:
>     I was under the impression that this fell under ACCUMULO-1726
>
> kturner wrote:
>     How is adding a redundant method to the API now related to 1726?

Misunderstood, agree with your assessment.
> On Oct. 29, 2013, 3:25 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java, line 164
> > <https://reviews.apache.org/r/14972/diff/1/?file=371853#file371853line164>
> >
> >     Probably do not need to add this method.  I think most users connect using the instance name.  If they really want to connect using the instance id and pass config, can they use the constructor that only takes config?
>
> John Vines wrote:
>     Unless we decide to entirely drop support for the UUID based constructors, then we should have them mirror any additional functionality.
>
> kturner wrote:
>     Having ZooKeeperInstance(ClientConfiguration) changes things.  I am assuming this constructor can replicate the functionality of all the other existing constructors, is this correct?  I'm thinking we should be moving towards less constructors if ZooKeeperInstance(ClientConfiguration) exist and not more.

Agreed
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14972/#review27675
-----------------------------------------------------------
On Oct. 26, 2013, 2:36 a.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14972/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2013, 2:36 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1009
>     https://issues.apache.org/jira/browse/ACCUMULO-1009
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Michael Berman's October 13 patch for ACCUMULO-1009
>
>
> Diffs
> -----
>
>   .gitignore 1ffa452
>   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 5b5d041
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java bb5987d
>   core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 32c80f9
>   core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java 218bd36
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 0376304
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java 0dd86bf
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java f07139d
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java e7dabb5
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java bbbd0c3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java 908b8b3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java fe5003b
>   core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java c796cd2
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java 1cbb606
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 727bfec
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java 992990d
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java 13f9708