Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 16821: SQOOP-1266 Sqoop2: Introduce top level commands


Copy link to this message
-
Re: Review Request 16821: SQOOP-1266 Sqoop2: Introduce top level commands


> On Jan. 16, 2014, 7:23 p.m., Hari Shreedharan wrote:
> > For all 3 scripts, most of the script is copy-paste. Is there a reason we can't put it in one script and simply source that script?

Good point Hari! I was trying to do exactly that, however there is a chicken-egg problem. In order to reliably source a script from the same directory I need that fragment in order to get the "current" directory. Hence the copy-paste into all three scripts.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16821/#review32053
-----------------------------------------------------------
On Jan. 14, 2014, 5:45 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16821/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 5:45 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1266
>     https://issues.apache.org/jira/browse/SQOOP-1266
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've provided sqoop2-$commnand top level scripts for $command in "shell", "tool" and "server". I've chosen to encode the major version in the command name to make it easy to have side by side installation of both Sqoop 1 and 2 (e.g. sqoop2-tool instead of sqoop-tool). For the time being I've made the scripts very simple and just let them call the existing sqoop.sh. I would expect to remove the sqoop.sh in the future and move the entire functionality to these new top level scripts.
>
> I've also updated the documentation to use the new commands.
>
>
> Diffs
> -----
>
>   dist/src/main/bin/sqoop2-server PRE-CREATION
>   dist/src/main/bin/sqoop2-shell PRE-CREATION
>   dist/src/main/bin/sqoop2-tool PRE-CREATION
>   docs/src/site/sphinx/CommandLineClient.rst 22d6d4759ea5ec8624be08845693d47c0b607ea6
>   docs/src/site/sphinx/Installation.rst 97af41223f3528e32d3681b1e0ae9d618f2d8f37
>   docs/src/site/sphinx/Sqoop5MinutesDemo.rst 49e554b6613cbed740fe1ce336d9c60d1bba5d79
>   docs/src/site/sphinx/Tools.rst 1c7481fb895d0cd16686fd511a03786cef568630
>   docs/src/site/sphinx/Upgrade.rst 45d27bd8f1caccd0697c6b310b84a8f2ac74603d
>
> Diff: https://reviews.apache.org/r/16821/diff/
>
>
> Testing
> -------
>
> Verified the new commands on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>