Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> review process


Copy link to this message
-
Re: review process
I think you're the very first to use reviewboard for drill. We used to just
use Github's pull requests before.

If we are going for reviewboard, then I think all patches should go through
it.

>From recent experience Jacques has been handling all reviews, so I believe
if you have a +1 from a commiter you should be good.

Tim
On Tue, Mar 26, 2013 at 2:02 PM, David Alves <[EMAIL PROTECTED]> wrote:

> Hi All
>
>         I have a couple of questions about the review process:
>         - should we *always* submit a diff to review board? or should this
> only be done for "big" patches?
>         - how many +1's for a patch to be accepted? +1's only count
> originating from committers, correct?
>
> Best
> David
>
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB