Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request: Refactor physical operators to remove methods parameters that are always null


Copy link to this message
-
Re: Review Request: Refactor physical operators to remove methods parameters that are always null

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11203/#review20674
-----------------------------------------------------------

Ship it!
Looks good to me. I only have minor comments as below. Do you mind fixing them when you commit?

I also confirmed that all unit tests pass.
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java
<https://reviews.apache.org/r/11203/#comment42709>

    Can you fix indentation here?

src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ExpressionOperator.java
<https://reviews.apache.org/r/11203/#comment42710>

    Can you fix indentation here?

src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
<https://reviews.apache.org/r/11203/#comment42712>

    This isn't what you introduced, but I think this is incorrect.
    
    Shouldn't "in.getNextBigDecimal()" be "in.getNextBigInteger()" since we're casting BI to BD here?
- Cheolsoo Park
On May 16, 2013, 9:35 p.m., Julien Le Dem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11203/
> -----------------------------------------------------------
>
> (Updated May 16, 2013, 9:35 p.m.)
>
>
> Review request for pig, Daniel Dai, Dmitriy Ryaboy, Cheolsoo Park, and Bill Graham.
>
>
> Description
> -------
>
> Refactor physical operators to remove methods parameters that are always null
>
>
> This addresses bug PIG-3307.
>     https://issues.apache.org/jira/browse/PIG-3307
>
>
> Diffs
> -----
>
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MergeJoinIndexer.java d5aff3d
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigCombiner.java 6cfc8c0
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapBase.java 7c499f6
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapReduce.java 6145214
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java fc0112a
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Add.java 5bceca6
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/BinaryComparisonOperator.java 3e434f3
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ComparisonOperator.java 51d9f34
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ConstantExpression.java 7e4cffa
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Divide.java bdcc72b
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/EqualToExpr.java a767c36
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ExpressionOperator.java 9cca2c3
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GTOrEqualToExpr.java b5e3c83
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GreaterThanExpr.java f3b5d44
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LTOrEqualToExpr.java 35786c0
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LessThanExpr.java c9b3157
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Mod.java 1108846
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Multiply.java 2795b78
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/NotEqualToExpr.java 294f84a
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POAnd.java f24c2ac
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POBinCond.java 312f3ac