Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem


Copy link to this message
-
Re: Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem
Sean Busbey 2013-11-06, 19:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15279/#review28290
-----------------------------------------------------------

src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java
<https://reviews.apache.org/r/15279/#comment55071>

    please don't include formatting fixes unrelatd to the change.

src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java
<https://reviews.apache.org/r/15279/#comment55072>

    please don't include formatting fixes unrelated to the issue.

src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java
<https://reviews.apache.org/r/15279/#comment55074>

    Does this buy us much beyond just letting the original IOException propagate without wrapping?

src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java
<https://reviews.apache.org/r/15279/#comment55087>

    Include a note that this test class is not threadsafe.
    
    The default poms and build scripts don't run parallel unit tests. But I know the build speed is something we care about, so we'll get there eventually. Best to have a warning for future maintainers. How much detail to include is up to you.
    
    It won't work with JUnit 4.7+'s parallel, since they're in the same JVM:
    
    http://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html#Running_tests_in_parallel
    
    It will work with Surefire's fork and reuseForks=false, since that's a JVM per class
    
    http://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html#Forked_Test_Execution

src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java
<https://reviews.apache.org/r/15279/#comment55079>

    Should have an @After that restores Initialize.setZooReaderWriter

src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java
<https://reviews.apache.org/r/15279/#comment55092>

    Can you add a test that confirms when the underlying filesystem throws an exception on the exists call we get an IOException back out of checkInit?
- Sean Busbey
On Nov. 6, 2013, 7:02 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15279/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 7:02 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1556
>     https://issues.apache.org/jira/browse/ACCUMULO-1556
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> The Initialize class now generates clearer error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used.
>
> Note that to facilitate unit testing, the verification logic in Initialize.doInit() was refactored into a checkInit() method.
>
>
> Diffs
> -----
>
>   pom.xml 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8
>   src/server/pom.xml 6421bc69cda5116f9716d30adc3d510baa3bb7d6
>   src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc
>   src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15279/diff/
>
>
> Testing
> -------
>
> Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested successful initialization and correct emission of error messages when instance.dfs.uri was used and was not used. Also, implemented unit tests for altered code.
>
>
> Thanks,
>
> Bill Havanki
>
>