Israel Ekpo 2013-05-01, 11:58
Hey, this looks good to me!
One thing though, we do check in generated source code for
Thrift/Protobuf/Avro e.g. ThriftFlumeEvent.java. Can we remove these
classes from the cleanup? The changes will just get overwritten the next
time we generate the code.
On Wed, May 1, 2013 at 6:58 AM, Israel Ekpo <[EMAIL PROTECTED]> wrote:
> I wanted to get some feedback from others before proceeding with this.
> So, I recently opened a JIRA issue and submitted a patch that removes
> unwanted imports from the project.
> I was thinking about doing the same cleanup for unused variables/fields,
> references to generic types that should be
> parametized, unnecessary @SuppressWarning annotations etc.
> I came into these warnings in the files as I was going around adding
> javadocs and other documenation to the files.
> Is this cleanup something that will be helpful?
> If so then I can open another JIRA issue and upload patches for just the
> clean up changes.
Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org
Israel Ekpo 2013-05-02, 02:00