Sqoop, mail # dev - Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Jarek Cecho 2012-12-13, 01:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've added:
* A lot of log messages on various classes in execution engine
* log4j configuration file for tests to show the output correctly
This addresses bug SQOOP-762.
   https://issues.apache.org/jira/browse/SQOOP-762
Diffs
-----

  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java 0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 1f6714dcbb12916a6d350ad117c0bf4bac577a29
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java 7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 36eb65d16048eff22ea9ded079a2827e978fcf06
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 976d80b66e4c1466350db432295232778893ab86
  execution/mapreduce/src/test/resources/log4j.properties PRE-CREATION

Diff: https://reviews.apache.org/r/8562/diff/
Testing
-------
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Jarek Cecho 2012-12-14, 01:44

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/
-----------------------------------------------------------

(Updated Dec. 14, 2012, 1:44 a.m.)
Review request for Sqoop.
Changes
-------

Good catch, thank you Bilung!
Description
-------

I've added:
* A lot of log messages on various classes in execution engine
* log4j configuration file for tests to show the output correctly
This addresses bug SQOOP-762.
   https://issues.apache.org/jira/browse/SQOOP-762
Diffs (updated)
-----

  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java 0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 1f6714dcbb12916a6d350ad117c0bf4bac577a29
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java 7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 36eb65d16048eff22ea9ded079a2827e978fcf06
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 976d80b66e4c1466350db432295232778893ab86

Diff: https://reviews.apache.org/r/8562/diff/
Testing
-------
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Bilung Lee 2012-12-14, 01:33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/#review14477
-----------------------------------------------------------
One comment below. Thanks.
execution/mapreduce/src/test/resources/log4j.properties
<https://reviews.apache.org/r/8562/#comment30854>

Need a license header.
- Bilung Lee
On Dec. 13, 2012, 1:29 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8562/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2012, 1:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added:
> * A lot of log messages on various classes in execution engine
> * log4j configuration file for tests to show the output correctly
>
>
> This addresses bug SQOOP-762.
> https://issues.apache.org/jira/browse/SQOOP-762
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java 0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 1f6714dcbb12916a6d350ad117c0bf4bac577a29
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java 7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 36eb65d16048eff22ea9ded079a2827e978fcf06
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 976d80b66e4c1466350db432295232778893ab86
> execution/mapreduce/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Venkat Ranganathan 2012-12-13, 02:09

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/#review14415
-----------------------------------------------------------

Ship it!
Looks good. I thought whether we wanted INFO as the root logger level, but this being development release, DEBUG is more helpful

- Venkat Ranganathan
On Dec. 13, 2012, 1:29 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8562/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2012, 1:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added:
> * A lot of log messages on various classes in execution engine
> * log4j configuration file for tests to show the output correctly
>
>
> This addresses bug SQOOP-762.
> https://issues.apache.org/jira/browse/SQOOP-762
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java 0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 1f6714dcbb12916a6d350ad117c0bf4bac577a29
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java 7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 36eb65d16048eff22ea9ded079a2827e978fcf06
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 976d80b66e4c1466350db432295232778893ab86
> execution/mapreduce/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-762 Sqoop2: Improve logging in mapreduce execution engine

Jarek Cecho 2012-12-13, 03:30

> On Dec. 13, 2012, 2:09 a.m., Venkat Ranganathan wrote:
> > Looks good. I thought whether we wanted INFO as the root logger level, but this being development release, DEBUG is more helpful

Hi Venkat,
thank you very much for your review, I greatly appreciate that! Attached log4j configuration file is only for test, so it won't be used normally :-)

Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8562/#review14415
-----------------------------------------------------------
On Dec. 13, 2012, 1:29 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8562/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2012, 1:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added:
> * A lot of log messages on various classes in execution engine
> * log4j configuration file for tests to show the output correctly
>
>
> This addresses bug SQOOP-762.
> https://issues.apache.org/jira/browse/SQOOP-762
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java 0e0e53fe7c9db96a4025e2feaf22b5fe9a01d3cc
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java 1f6714dcbb12916a6d350ad117c0bf4bac577a29
> execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java 7f1b14435f16eaa5e6d1563bfbe19d705ee4be3e
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 36eb65d16048eff22ea9ded079a2827e978fcf06
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java fcedf52b8cbff1b727fd3b90360605a01d145e3d
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 976d80b66e4c1466350db432295232778893ab86
> execution/mapreduce/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>