Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-1773. File Channel worker thread should not be daemon


Copy link to this message
-
Re: Review Request: FLUME-1773. File Channel worker thread should not be daemon


> On Dec. 10, 2012, 8:57 p.m., Brock Noland wrote:
> > Looks like a good patch. There are unit tests where we set the checkpoint interval to 1 millisecond and is then overridden to 1 second by the current code. I think we should probably update the unit tests or add the Math.max() back in? Thoughts?

Brock - the latest patch reverts the checkpoint interval to Millis
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8433/#review14260
-----------------------------------------------------------
On Dec. 10, 2012, 8:52 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8433/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:52 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Using a single threaded scheduled executor, which is stopped when the channel is killed.
>
>
> This addresses bug FLUME-1773.
>     https://issues.apache.org/jira/browse/FLUME-1773
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java ea98e5d
>
> Diff: https://reviews.apache.org/r/8433/diff/
>
>
> Testing
> -------
>
> All unit tests pass
>
>
> Thanks,
>
> Hari Shreedharan
>
>