Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-605 Generic JDBC connector for import


+
Bilung Lee 2012-10-01, 18:01
+
Bilung Lee 2012-10-08, 19:36
Copy link to this message
-
Re: Review Request: SQOOP-605 Generic JDBC connector for import
Jarek Cecho 2012-10-08, 23:03

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7379/#review12252
-----------------------------------------------------------

Ship it!
Hi Bilung,
thank you very much for your changes. I do have just couple of nits - all white space characters at the end of lines. Please remove them and upload your patch to the JIRA and I'll commit it. You do not have to update this review.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/7379/#comment25994>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/7379/#comment25995>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/7379/#comment25996>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
<https://reviews.apache.org/r/7379/#comment25997>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/7379/#comment25998>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
<https://reviews.apache.org/r/7379/#comment25999>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
<https://reviews.apache.org/r/7379/#comment26000>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
<https://reviews.apache.org/r/7379/#comment26001>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
<https://reviews.apache.org/r/7379/#comment26002>

    Nit: Could you remove the trailing spaces?

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
<https://reviews.apache.org/r/7379/#comment26003>

    Nit: Could you remove the trailing spaces?
Regards,

Jarcec

- Jarek Cecho
On Oct. 8, 2012, 7:35 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7379/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2012, 7:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Provide import initializer, partitioner, and extractor for Generic JDBC connector.
> Also modify the pom.xml to have better version management.
>
>
> This addresses bug SQOOP-605.
>     https://issues.apache.org/jira/browse/SQOOP-605
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/pom.xml 382c669
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 4363e0a
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java 0e45241
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java PRE-CREATION
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java PRE-CREATION
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 2b0b621
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java aa7359e
+
Bilung Lee 2012-10-08, 23:16