Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-942 Sqoop2: Refactore code repetition in SqoopRequests objects


Copy link to this message
-
Review Request: SQOOP-942 Sqoop2: Refactore code repetition in SqoopRequests objects

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9991/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've moved the logic of applying validations from SqoopRequests to SqoopClient as it logically belongs there.
This addresses bug SQOOP-942.
    https://issues.apache.org/jira/browse/SQOOP-942
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 554a8fe97a14db3f03e0adfc200871391bfb1b64
  client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 5ed38b638618d13ecd0d1b3ed10b580514d828ea

Diff: https://reviews.apache.org/r/9991/diff/
Testing
-------

Unit and integration tests seems to be passing.
Thanks,

Jarek Cecho

+
Kathleen Ting 2013-03-26, 07:42