Sqoop, mail # dev - Review Request: SQOOP-877 Increase field size of output.outputDirectory property value from 25 to 50

Review Request: SQOOP-877 Increase field size of output.outputDirectory property value from 25 to 50

Jarek Cecho 2013-02-15, 04:18

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9463/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've increased the size to 255 to ensure that we can contain very long paths.
This addresses bug SQOOP-877.
   https://issues.apache.org/jira/browse/SQOOP-877
Diffs
-----

  core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java c97a5de939dacd93893a83171633e04fe4cd8e96
  core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java 1b2cec70ea42eeb60015849051fc2e744a63e6ec

Diff: https://reviews.apache.org/r/9463/diff/
Testing
-------

Unit tests seems to be passing and I've verified this on real cluster.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-877 Increase field size of output.outputDirectory property value from 25 to 50

Cheolsoo Park 2013-02-22, 21:22

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9463/#review16966
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Feb. 15, 2013, 4:18 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9463/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 4:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've increased the size to 255 to ensure that we can contain very long paths.
>
>
> This addresses bug SQOOP-877.
> https://issues.apache.org/jira/browse/SQOOP-877
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java c97a5de939dacd93893a83171633e04fe4cd8e96
> core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java 1b2cec70ea42eeb60015849051fc2e744a63e6ec
>
> Diff: https://reviews.apache.org/r/9463/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've verified this on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>