Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request 14030: [PIG-3255] Avoid extra byte array copy in streaming deserialize


Copy link to this message
-
Re: Review Request 14030: [PIG-3255] Avoid extra byte array copy in streaming deserialize

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14030/#review26117
-----------------------------------------------------------

http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigStreamingBase.java
<https://reviews.apache.org/r/14030/#comment50975>

    @Override ?
Looks good to me otherwise.

- Daniel Dai
On Sept. 13, 2013, 8:11 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14030/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 8:11 p.m.)
>
>
> Review request for pig and Alan Gates.
>
>
> Bugs: PIG-3255
>     https://issues.apache.org/jira/browse/PIG-3255
>
>
> Repository: pig
>
>
> Description
> -------
>
> Added a new abstract class PigStreamingBase to have the new APIs for serializing and deserializing..Deprecated PigtoSTreaming and StreamingToPig
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigStreamingBase.java PRE-CREATION
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigToStream.java 1523070
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/StreamToPig.java 1523070
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/PigStreaming.java 1523070
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/data/WritableByteArray.java PRE-CREATION
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/streaming/InputHandler.java 1523070
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/streaming/OutputHandler.java 1523070
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/util/StorageUtil.java 1523070
>
> Diff: https://reviews.apache.org/r/14030/diff/
>
>
> Testing
> -------
>
> No new unit tests. TestStreaming and TestStreamingLocal cover the changes and the tests passes.
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>