Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request 12803: Fix for Flume-2109, Take 3. Incorporated Review comments and implementation in sysc with Avro source


+
Ashish Paliwal 2013-07-22, 07:56
+
Hari Shreedharan 2013-08-01, 22:31
+
Ashish 2013-08-02, 01:40
+
Hari Shreedharan 2013-08-02, 01:42
+
Ashish 2013-08-02, 01:45
Copy link to this message
-
Re: Review Request 12803: Fix for Flume-2109, Take 3. Incorporated Review comments and implementation in sysc with Avro source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12803/#review24501
-----------------------------------------------------------

Ship it!
As discussed, please file a follow up jira to add a new test. please update the log message to INFO and attach the patch to the jira.

- Hari Shreedharan
On July 22, 2013, 7:56 a.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12803/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 7:56 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2109
>     https://issues.apache.org/jira/browse/FLUME-2109
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Fix for Flume-2109, to support HTTPS.
> Incorporates Review comments from Alex
> Implementation refined to be as close to Avro Source, like SSL port is not to be defined, the port value shall be used
> Documentation updated to reflect the changes
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
>   flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
>
> Diff: https://reviews.apache.org/r/12803/diff/
>
>
> Testing
> -------
>
> Unit Test case written to test SSL functionality
>
>
> Thanks,
>
> Ashish Paliwal
>
>

+
Hari Shreedharan 2013-08-02, 05:12
+
Ashish 2013-08-02, 05:14
+
Hari Shreedharan 2013-08-02, 05:22
+
Ashish 2013-08-02, 05:32